modal editor - tweaks to UI depending on setting#300082
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the modal editor overlay UI to better reflect the workbench.editor.useModal setting, primarily by dynamically changing tab visibility based on mode and editor count.
Changes:
- Update modal editor part options so tabs can be shown when multiple editors are open (and only in
useModal=allmode). - Rework modal drag/centering math to clamp/center within the main container more consistently.
- Add unit tests to validate tab visibility behavior for
useModal=allvssome, and exposeconfigurationServicetoEditorPartsubclasses.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/services/editor/test/browser/modalEditorGroup.test.ts | Adds tests asserting modal tab visibility changes based on useModal mode and editor count. |
| src/vs/workbench/browser/parts/editor/modalEditorPart.ts | Implements dynamic modal showTabs enforcement and updates modal positioning calculations. |
| src/vs/workbench/browser/parts/editor/editorPart.ts | Changes configurationService visibility to protected to enable subclass access. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lszomoru
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.