Remove confusing chatResource from NewChatSessionOpenOptions#300236
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 9, 2026
Merged
Remove confusing chatResource from NewChatSessionOpenOptions#300236mjbvz merged 1 commit intomicrosoft:mainfrom
chatResource from NewChatSessionOpenOptions#300236mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Looks like this is no longer being used
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused/unclear chatResource override from the internal NewChatSessionOpenOptions shape and standardizes local sidebar session resource creation by using LocalChatSessionUri.getNewSessionUri().
Changes:
- Removed
chatResource?: UriComponentsfromNewChatSessionOpenOptions. - Simplified
getResourceForNewChatSessionby removing the revive/override branch. - Switched local sidebar “new session” resource creation to
LocalChatSessionUri.getNewSessionUri().
DonJayamanne
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this is no longer being used
Also adopts
LocalChatSessionUri.getNewSessionUri