Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
@deepak1556Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches the BrowserView CDP connection used by the shared-process Playwright integration from a local WebSocket proxy endpoint to an IPC-based CDP message transport between the shared process and Electron main.
Changes:
- Replace
getDebugWebSocketEndpoint()withsendCDPMessage()+onCDPMessageto carry CDP traffic over IPC. - Extend
CDPBrowserProxywith a message-based request/response surface (sendMessage+onMessage) suitable for transports like IPC. - Remove the Electron-main
BrowserViewCDPProxyServerservice and its registration.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/browserView/node/playwrightService.ts | Connects Playwright to BrowserView CDP via an IPC-backed transport instead of connectOverCDP(endpoint) |
| src/vs/platform/browserView/node/browserViewGroupRemoteService.ts | Exposes CDP send + message event forwarding on the remote IBrowserViewGroup proxy |
| src/vs/platform/browserView/electron-main/browserViewGroupMainService.ts | Implements IPC entry points for sending CDP requests and streaming CDP messages from main |
| src/vs/platform/browserView/electron-main/browserViewGroup.ts | Lazily instantiates CDPBrowserProxy and exposes sendCDPMessage/onCDPMessage |
| src/vs/platform/browserView/electron-main/browserViewDebugger.ts | Renames ICDPConnection.sendMessage to sendCommand to clarify semantics |
| src/vs/platform/browserView/electron-main/browserViewCDPProxyServer.ts | Deleted: removes local WebSocket proxy/token endpoint approach |
| src/vs/platform/browserView/common/cdp/types.ts | Renames ICDPConnection.sendMessage to sendCommand |
| src/vs/platform/browserView/common/cdp/proxy.ts | Adds message-based handling (sendMessage + onMessage) and updates routing to sendCommand |
| src/vs/platform/browserView/common/browserViewGroup.ts | Updates group/service contracts to support CDP over IPC |
| src/vs/code/electron-main/app.ts | Removes BrowserViewCDPProxyServer service wiring |
jruales
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.