Disable screenshots until time out bug is fixed#300293
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the Component Screenshots GitHub Actions job while a timeout-related issue is being investigated, preventing the screenshot workflow from running its steps in CI.
Changes:
- Adds a job-level condition to skip the
screenshotsjob unconditionally.
|
|
||
| jobs: | ||
| screenshots: | ||
| if: false # temporarily disabled |
There was a problem hiding this comment.
jobs.<job_id>.if is expected to be a GitHub Actions expression string. Using the YAML boolean false here can be parsed as a boolean value (not an expression) and may cause the workflow to be rejected or behave unexpectedly. Consider switching to an explicit expression (e.g. if: ${{ false }}) and/or quoting the value, and include a tracking reference (issue/PR) in the comment since this is meant to be temporary.
Suggested change
| if: false # temporarily disabled | |
| if: ${{ false }} # temporarily disabled (TODO: add tracking issue/PR reference) |
DonJayamanne
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.