Reduce any usage in a few more tests#300352
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the codebase-wide effort from #269213 by removing a few remaining as any type assertions in tests, replacing them with more precise mock shapes and stronger types.
Changes:
- Update chat request parser tests to stub services without
as anyby supplying required service-brand and readonly fields. - Update CDP accessibility domain tests to use
AXPropertyNamedirectly, removing anas anycast. - Update quick input tests to stub
ILayoutServicewithoutas anyby including_serviceBrand.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/requestParser/chatRequestParser.test.ts | Makes service mocks type-correct (e.g., _serviceBrand, events/booleans) so instantiationService.stub(...) no longer needs as any. |
| src/vs/platform/webContentExtractor/test/electron-main/cdpAccessibilityDomain.test.ts | Uses AXPropertyName for createAXProperty to avoid name as any. |
| src/vs/platform/quickinput/test/browser/quickinput.test.ts | Removes as any from the ILayoutService stub by providing _serviceBrand. |
DonJayamanne
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #269213