chat: simplify symbol reference cache to an array#300489
Merged
connor4312 merged 3 commits intomainfrom Mar 10, 2026
Merged
Conversation
Replaces the Map-based symbol reference cache with a simple array that keeps only the last 3 copied symbols. This removes the 15-second TTL expiration logic and relies on insertion order instead. - Changed symbolReferenceCache from Map to array - Removed symbolCacheTtlMs constant and pruning logic - Added symbolCacheMaxSize constant for max entries - Simplified cache lookups with array.find() - Automatically evicts oldest entry when exceeding capacity (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the chat “paste symbol reference” caching logic by replacing the previous Map + TTL-based cache with a small fixed-size array that retains only the most recently cached entries.
Changes:
- Replaced
symbolReferenceCachefromMapto an array with a max size of 3 entries. - Removed the TTL constant and cache pruning logic.
- Simplified cache lookup to an array search and eviction by removing the oldest entry.
You can also share your feedback on Copilot code review. Take the survey.
Closed
rzhao271
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Map-based symbol reference cache with a simple array that
keeps only the last 3 copied symbols. This removes the 15-second TTL
expiration logic and relies on insertion order instead.
(Commit message generated by Copilot)