customizations: fix hook secondary text being truncated#300614
Merged
joshspicer merged 3 commits intomainfrom Mar 11, 2026
Merged
customizations: fix hook secondary text being truncated#300614joshspicer merged 3 commits intomainfrom
joshspicer merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses AI Customization list rendering so hook items (which display shell commands) no longer have their secondary text truncated to the first sentence, avoiding loss of important command text in the UI.
Changes:
- Extracted secondary-text logic into a shared utility (
truncateToFirstSentence,getCustomizationSecondaryText). - Updated the AI customization list item renderer to keep full hook secondary text while still truncating other types.
- Added unit tests covering truncation behavior and hook/non-hook secondary text selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/aiCustomization/aiCustomizationListWidget.test.ts | Adds tests for truncation + hook/non-hook secondary text behavior. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidgetUtils.ts | Introduces shared helpers for secondary text selection and truncation. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts | Switches renderer to use the new helper so hooks aren’t truncated. |
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts
Outdated
Show resolved
Hide resolved
…izationListWidget.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pwang347
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.