Skip to content

Sessions: update new chat isolation picker behavior#300791

Merged
sandy081 merged 5 commits intomicrosoft:mainfrom
sandy081:copilot/long-walrus
Mar 11, 2026
Merged

Sessions: update new chat isolation picker behavior#300791
sandy081 merged 5 commits intomicrosoft:mainfrom
sandy081:copilot/long-walrus

Conversation

@sandy081
Copy link
Copy Markdown
Member

  • rename isolation labels to "Copilot CLI" and "Local"
  • keep isolation picker visible but disabled when github.copilot.chat.cli.isolationOption.enabled is false
  • enforce worktree mode when isolation option is disabled
  • react to configuration changes at runtime in new chat view pane
  • keep branch/sync/default approvals placement updates in new chat view

- Swap mode and model picker positions in toolbar
- Move Default Approvals next to isolation mode picker with gap
- Rename Folder/Worktree labels to Local/Copilot CLI
- Gate isolation picker on github.copilot.chat.cli.isolationOption.enabled
- Show picker as disabled (not hidden) when config is off
- Add setEnabled API to IsolationModePicker
- Listen for config changes and enforce worktree mode when disabled

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 13:44
@vs-code-engineering vs-code-engineering bot added this to the 1.112.0 milestone Mar 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Sessions window “New Chat” experience to reflect the latest isolation-mode UX and to react to runtime configuration changes, while keeping existing picker placement behavior intact.

Changes:

  • Renames isolation mode labels to “Copilot CLI” and “Local”, and adds a disabled-but-visible state for the isolation picker.
  • Reacts to github.copilot.chat.cli.isolationOption.enabled changes at runtime and enforces worktree mode when the option is disabled.
  • Adds an Alt-modified send action that can open a new chat after sending.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/vs/sessions/contrib/chat/browser/sessionTargetPicker.ts Adds enable/disable support for the isolation picker and updates isolation option labels.
src/vs/sessions/contrib/chat/browser/newChatViewPane.ts Reacts to isolation option config changes, enforces worktree when disabled, and adds Alt-modified send behavior.
Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/chat/browser/sessionTargetPicker.ts:255

  • The localization key isolationMode.worktree now maps to the English string “Copilot CLI” (previously “Worktree”). Reusing the same key can surface incorrect existing translations. Please introduce a new key (or ensure translation resources are updated) for the renamed label.
				kind: ActionListItemKind.Action,
				label: localize('isolationMode.worktree', "Copilot CLI"),
				group: { title: '', icon: Codicon.worktree },
				item: 'worktree',
			},

Comment thread src/vs/sessions/contrib/chat/browser/sessionTargetPicker.ts
Comment thread src/vs/sessions/contrib/chat/browser/newChatViewPane.ts Outdated
Comment thread src/vs/sessions/contrib/chat/browser/newChatViewPane.ts Outdated
Comment thread src/vs/sessions/contrib/chat/browser/sessionTargetPicker.ts Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sandy081 sandy081 enabled auto-merge (squash) March 11, 2026 14:05
@sandy081 sandy081 merged commit a5cf4dd into microsoft:main Mar 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants