Add sessions support to translation resources and update related logic#300889
Merged
TylerLeonhardt merged 3 commits intomainfrom Mar 11, 2026
Merged
Add sessions support to translation resources and update related logic#300889TylerLeonhardt merged 3 commits intomainfrom
TylerLeonhardt merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the build-time localization (XLF) resource mapping to recognize the vs/sessions source tree as its own Transifex project (vscode-sessions), aligning Sessions with existing editor/workbench/server localization handling.
Changes:
- Add
vscode-sessionsproject handling inbuild/lib/i18n.ts(getResource) and adjust translation import logic to skip sessions/setup inprepareI18nPackFiles. - Add a
sessionsresource group tobuild/lib/i18n.resources.json. - Extend the i18n unit test and the local ESLint translation reminder rule to account for Sessions paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build/lib/test/i18n.test.ts | Adds assertions for vs/sessions resource mapping. |
| build/lib/i18n.ts | Introduces vscode-sessions project mapping for XLF bundling and adjusts import filtering. |
| build/lib/i18n.resources.json | Adds a sessions section listing Sessions resources/projects. |
| .eslint-plugin-local/code-translation-remind.ts | Attempts to include Sessions contrib paths in the translation resource reminder rule. |
You can also share your feedback on Copilot code review. Take the survey.
dmitrivMS
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300278