Skip to content

chat rendering fix for working + cli specific issues#301015

Merged
justschen merged 4 commits intomainfrom
justin/ferrothorn
Mar 12, 2026
Merged

chat rendering fix for working + cli specific issues#301015
justschen merged 4 commits intomainfrom
justin/ferrothorn

Conversation

@justschen
Copy link
Collaborator

fix issue with padding + working showing up DOUBLE

Copilot AI review requested due to automatic review settings March 12, 2026 04:58
@vs-code-engineering vs-code-engineering bot added this to the 1.112.0 milestone Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an isAttachedToThinking flag to tool invocation parts so the chat renderer can correctly suppress the “working” progress indicator when a tool invocation is (or will be) rendered inside the Thinking container, and refines Thinking container behavior around single-item restoration.

Changes:

  • Extend tool invocation model types with isAttachedToThinking and set/clear it during Thinking attachment transitions.
  • Update Thinking container logic to track a single tool invocation item and only restore it to the main flow once the tool is complete.
  • Adjust chat UI spacing and update affected tests/mocks.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatSubagentContentPart.test.ts Updates test mock tool invocations to include the new isAttachedToThinking field.
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionApprovalModel.test.ts Updates test helper mock tool invocations to include isAttachedToThinking.
src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatToolInvocation.ts Adds default isAttachedToThinking state to the ChatToolInvocation implementation.
src/vs/workbench/contrib/chat/common/chatService/chatService.ts Extends IChatToolInvocation and IChatToolInvocationSerialized type definitions with the new field.
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Tweaks spacing for the progress container in the chat UI.
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Suppresses “working” when the last part is a tool invocation attached (or about to be attached) to Thinking; sets/clears the flag during render/transition.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts Tracks tool invocation attachment state and refines single-item restoration behavior based on tool completion.

You can also share your feedback on Copilot code review. Take the survey.

@justschen justschen enabled auto-merge (squash) March 12, 2026 05:45
@justschen justschen merged commit 9c8a42f into main Mar 12, 2026
20 checks passed
@justschen justschen deleted the justin/ferrothorn branch March 12, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants