chat rendering fix for working + cli specific issues#301015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an isAttachedToThinking flag to tool invocation parts so the chat renderer can correctly suppress the “working” progress indicator when a tool invocation is (or will be) rendered inside the Thinking container, and refines Thinking container behavior around single-item restoration.
Changes:
- Extend tool invocation model types with
isAttachedToThinkingand set/clear it during Thinking attachment transitions. - Update Thinking container logic to track a single tool invocation item and only restore it to the main flow once the tool is complete.
- Adjust chat UI spacing and update affected tests/mocks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatSubagentContentPart.test.ts | Updates test mock tool invocations to include the new isAttachedToThinking field. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionApprovalModel.test.ts | Updates test helper mock tool invocations to include isAttachedToThinking. |
| src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatToolInvocation.ts | Adds default isAttachedToThinking state to the ChatToolInvocation implementation. |
| src/vs/workbench/contrib/chat/common/chatService/chatService.ts | Extends IChatToolInvocation and IChatToolInvocationSerialized type definitions with the new field. |
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Tweaks spacing for the progress container in the chat UI. |
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Suppresses “working” when the last part is a tool invocation attached (or about to be attached) to Thinking; sets/clears the flag during render/transition. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts | Tracks tool invocation attachment state and refines single-item restoration behavior based on tool completion. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Show resolved
Hide resolved
bbacec3 to
b4d6378
Compare
jruales
approved these changes
Mar 12, 2026
jruales
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue with padding + working showing up DOUBLE