Fix focus issue and turn on update title bar entry for Insiders#301520
Merged
Fix focus issue and turn on update title bar entry for Insiders#301520
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the experimental update title bar indicator behavior to be enabled by default in non-stable builds and to avoid stealing focus when its tooltip is shown programmatically.
Changes:
- Make
update.titleBardefault toactionablefor non-stable (product.quality !== 'stable') builds. - Allow the update title bar tooltip to be shown without focusing by default, while focusing when opened via the indicator action.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts | Adds an optional focus parameter to control whether the instant hover is focused; uses focus when invoked from the indicator action. |
| src/vs/platform/update/common/update.config.contribution.ts | Changes the default for update.titleBar to be actionable on non-stable builds by consulting product.quality. |
deepak1556
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301121
Enabled new update UI in Insiders in
actionablemode by default.