Skip to content

Fix focus issue and turn on update title bar entry for Insiders#301520

Merged
dmitrivMS merged 2 commits intomainfrom
dev/dmitriv/update-bug-fixes
Mar 13, 2026
Merged

Fix focus issue and turn on update title bar entry for Insiders#301520
dmitrivMS merged 2 commits intomainfrom
dev/dmitriv/update-bug-fixes

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

Fixes #301121

Enabled new update UI in Insiders in actionable mode by default.

Copilot AI review requested due to automatic review settings March 13, 2026 15:56
@dmitrivMS dmitrivMS self-assigned this Mar 13, 2026
@dmitrivMS dmitrivMS added the install-update VS Code installation and upgrade system issues label Mar 13, 2026
@dmitrivMS dmitrivMS added this to the 1.112.0 milestone Mar 13, 2026
@dmitrivMS dmitrivMS enabled auto-merge (squash) March 13, 2026 15:56
@dmitrivMS dmitrivMS changed the title Fix focus issue and turn on update title bar entry for insiders Fix focus issue and turn on update title bar entry for Insiders Mar 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the experimental update title bar indicator behavior to be enabled by default in non-stable builds and to avoid stealing focus when its tooltip is shown programmatically.

Changes:

  • Make update.titleBar default to actionable for non-stable (product.quality !== 'stable') builds.
  • Allow the update title bar tooltip to be shown without focusing by default, while focusing when opened via the indicator action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts Adds an optional focus parameter to control whether the instant hover is focused; uses focus when invoked from the indicator action.
src/vs/platform/update/common/update.config.contribution.ts Changes the default for update.titleBar to be actionable on non-stable builds by consulting product.quality.

@dmitrivMS dmitrivMS merged commit 5789fa4 into main Mar 13, 2026
20 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/update-bug-fixes branch March 13, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-update VS Code installation and upgrade system issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New 'Update' UI pulls focus

3 participants