Skip to content

Misc debug panel UX fixes#301628

Merged
pwang347 merged 5 commits intomainfrom
pawang/uxImprovements
Mar 14, 2026
Merged

Misc debug panel UX fixes#301628
pwang347 merged 5 commits intomainfrom
pawang/uxImprovements

Conversation

@pwang347
Copy link
Copy Markdown
Member

@pwang347 pwang347 commented Mar 13, 2026

Support resizing the tool call panel
Allow to select time stamps

Fixes #301259
Fixes #301261
Fixes #301263

Copilot AI review requested due to automatic review settings March 13, 2026 23:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces several UX improvements to the chat debug panel:

  • Adds number formatting (locale-aware) for token counts, durations, and other numeric values
  • Replaces the fixed-width detail panel with a resizable sash-based panel
  • Adds scrollable elements to detail panel and collapsible sections
  • Adds a right-click context menu on debug events with copy and filter actions
  • Enables JSON syntax highlighting for model turn sections
  • Filters out 'unknown' status from display
  • Removes auto-navigation to new sessions from the home view

Changes:

  • Number formatting with safeIntl.NumberFormat() and .toLocaleString() across event detail renderers
  • Resizable detail panel via Sash with DomScrollableElement for proper scrolling
  • Context menu with copy/filter actions and refactored event text helpers

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
chatDebugEventDetailRenderer.ts Added safeIntl.NumberFormat() for locale-aware number formatting
chatDebugEventList.ts Extracted getEventCreatedText, getEventNameText, getEventDetailsText as exported helpers; added number formatting
chatDebugModelTurnContentRenderer.ts Made renderModelTurnContent async with JSON syntax highlighting for sections; added toLocaleString() formatting; filters out 'unknown' status
chatDebugToolCallContentRenderer.ts Exported tryParseJSON and renderSection for reuse
chatDebugDetailPanel.ts Added resizable sash, DomScrollableElement, width tracking, and race-condition guard for async rendering
chatDebugLogsView.ts Added context menu with copy/filter actions; relayout on detail panel width changes
chatDebugCollapsible.ts Wrapped section content in DomScrollableElement
chatDebug.css Added position: relative for sash anchoring; removed overflow-y: auto (now handled by scrollable elements); removed fixed width
chatDebugEditor.ts Removed auto-navigation to new sessions
chatDebugEventDetailRenderer.test.ts Adjusted test values below 1000 to avoid locale-dependent formatting issues

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/vs/workbench/contrib/chat/browser/chatDebug/media/chatDebug.css Outdated
vijayupadya
vijayupadya previously approved these changes Mar 13, 2026
@pwang347 pwang347 marked this pull request as ready for review March 13, 2026 23:57
@vs-code-engineering vs-code-engineering bot added this to the 1.112.0 milestone Mar 13, 2026
@pwang347 pwang347 merged commit 9192689 into main Mar 14, 2026
20 checks passed
@pwang347 pwang347 deleted the pawang/uxImprovements branch March 14, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected a "copy" or "open in editor" on embedded parts Scrollbars in flyouts are unstyled Use number formatting for token counts in debug log

3 participants