Update menu styles and improve sticky scroll appearance#302172
Merged
mrleemurray merged 2 commits intomainfrom Mar 16, 2026
Merged
Update menu styles and improve sticky scroll appearance#302172mrleemurray merged 2 commits intomainfrom
mrleemurray merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates VS Code theming and CSS so menus use dedicated menu selection colors and sticky scroll uses a themeable shadow color, aiming for more consistent visuals across themes.
Changes:
- Switch default menu selection colors to
menu.selectionForeground/menu.selectionBackgroundtokens. - Update sticky scroll shadow to use the
editorStickyScroll.shadowtoken (with fixed offsets). - Add a CSS border to
.monaco-menuusing themenu.bordertoken.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/platform/theme/browser/defaultStyles.ts | Updates default menu selection colors to menu-specific theme tokens. |
| src/vs/editor/contrib/stickyScroll/browser/stickyScroll.css | Replaces generic shadow variable with sticky-scroll-specific shadow token usage. |
| src/vs/base/browser/ui/menu/menu.ts | Adds a CSS border rule to the menu widget styling. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
deepak1556
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the menu's visual design by updating styles and improving the appearance of the sticky scroll feature. This includes adjustments to borders, shadows, and selection colors for better consistency and usability.