Skip to content

chore: add logs to track network process lifetime#302197

Merged
deepak1556 merged 1 commit intomainfrom
robo/add_network_process_events
Mar 16, 2026
Merged

chore: add logs to track network process lifetime#302197
deepak1556 merged 1 commit intomainfrom
robo/add_network_process_events

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 added this to the 1.113.0 milestone Mar 16, 2026
@deepak1556 deepak1556 self-assigned this Mar 16, 2026
Copilot AI review requested due to automatic review settings March 16, 2026 17:40
@deepak1556 deepak1556 enabled auto-merge (squash) March 16, 2026 17:40
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/code/electron-main/app.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds main-process logging in the Electron CodeApplication startup flow to help diagnose the Network Service process lifecycle (launched / exited), addressing the linked internalbacklog issue.

Changes:

  • Listen for Electron app events related to the network process (network-process-launched, network-process-gone).
  • Emit log lines containing PID and termination details to aid lifetime tracking.

You can also share your feedback on Copilot code review. Take the survey.

@deepak1556 deepak1556 merged commit 6c3a461 into main Mar 16, 2026
24 checks passed
@deepak1556 deepak1556 deleted the robo/add_network_process_events branch March 16, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants