Update menu selection colors to use list hover styles#302397
Merged
mrleemurray merged 1 commit intomainfrom Mar 17, 2026
Merged
Update menu selection colors to use list hover styles#302397mrleemurray merged 1 commit intomainfrom
mrleemurray merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the default menu item selection styling in the theming layer to align menu selection colors with list hover colors, aiming to improve UI consistency.
Changes:
- Updated
defaultMenuStylesto uselistHoverForeground/listHoverBackgroundfor menu selection colors. - Removed unused menu selection color identifiers from the
colorRegistryimport list indefaultStyles.ts.
sandy081
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust menu selection colors to align with list hover styles for improved consistency in the user interface. This change enhances the visual experience when interacting with menu items.