Improve CI status widget icons and layout in sessions changes view#302425
Merged
Improve CI status widget icons and layout in sessions changes view#302425
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent Sessions Changes view CI status widget to support dynamic height/layout coordination with the changes tree, and refreshes some CI status visuals (icons/colors) to better distinguish states.
Changes:
- Add height/visibility APIs and a parent-driven
layout()method toCIStatusWidget, plus a height-change event for relayout. - Update
ChangesViewPane.layoutTree()to allocate space between the changes tree and CI widget (including min/max CI body constraints). - Adjust pending-state styling and update icons used for “pending/queued” and the “Fix Checks” action.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/browser/media/ciStatusWidget.css | Tweaks pending-state icon coloring for header vs check rows. |
| src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts | Adds desired height/visibility + relayout signaling and exposes a layout API; updates icons. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Reworks layout computation to share vertical space between tree and CI widget. |
You can also share your feedback on Copilot code review. Take the survey.
bpasero
previously approved these changes
Mar 17, 2026
… compatibility The spinningLoading ThemeIcon (id: loading~spin) gets rendered as a single CSS class 'codicon-loading~spin' by ResourceLabels, which doesn't match the '.codicon-loading::before' CSS rule needed for the icon content. Using Codicon.loading directly produces the class 'codicon-loading', which has both the icon glyph and the spin animation defined in codicon-modifiers.css. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bpasero
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the CI checks list in the sessions window changes view with better icons and proper layout/scrolling behavior.
Icon improvements
lightbulbAutofixcodicon instead ofsparkleLayout improvements
onDidChangeHeightevent on expand/collapse and data changes to trigger parent re-layoutlayoutTreecollaboratively distributes space between the changes tree and CI widget