chore: disallow node version untested for development#302550
Merged
deepak1556 merged 2 commits intomainfrom Mar 17, 2026
Merged
chore: disallow node version untested for development#302550deepak1556 merged 2 commits intomainfrom
deepak1556 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the repo’s npm preinstall Node.js version check to prevent using Node versions that haven’t been built/tested in CI, avoiding toolchain/V8-related native build failures in the build/ dependencies.
Changes:
- Switch the Node.js version validation from “>= .nvmrc” semantics to requiring the same major version as
.nvmrc(while still enforcing a minimum minor/patch). - Update the console error message shown when the Node.js version check fails.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
joshspicer
approved these changes
Mar 17, 2026
bpasero
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain Node.js versions bring in V8 that bump minimum C++ requirements without bumping
-stdflag which can cause dependencies inside ourbuildfolder to fail compilation. Restrict version used for development to what is built and tested in CI.