Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new component-explorer fixtures under src/vs/workbench/test/browser/componentFixtures/ to broaden UI coverage for additional workbench/editor components (peek references, image carousel, and chat input).
Changes:
- Add a Peek References widget fixture backed by an in-memory editor model.
- Add an Image Carousel editor fixture with generated in-memory PNG images and multiple collection layouts.
- Add a Chat Input fixture with menu/tooling/todos/artifacts variations using mocked services.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/peekReference.fixture.ts | Adds a themed fixture that renders the references peek UI inside a code editor. |
| src/vs/workbench/test/browser/componentFixtures/imageCarousel.fixture.ts | Adds themed fixtures for the Image Carousel editor with several sample collections. |
| src/vs/workbench/test/browser/componentFixtures/chatInput.fixture.ts | Adds themed fixtures for ChatInputPart across multiple states (default, artifacts, edits, todos). |
Comment on lines
+119
to
+121
| const model = new ReferencesModel(links, 'processFile'); | ||
| disposableStore.add(model); | ||
| referenceWidget.setModel(model); |
Comment on lines
+105
to
+106
| // eslint-disable-next-line local/code-no-dangerous-type-assertions | ||
| reg.defineInstance(ITextModelService, new class extends mock<ITextModelService>() { override async createModelReference() { return { object: { textEditorModel: null }, dispose() { } } as unknown as Awaited<ReturnType<ITextModelService['createModelReference']>>; } }()); |
src/vs/workbench/test/browser/componentFixtures/imageCarousel.fixture.ts
Show resolved
Hide resolved
src/vs/workbench/test/browser/componentFixtures/peekReference.fixture.ts
Show resolved
Hide resolved
148d796 to
0206bda
Compare
roblourens
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.