Add hooks execution logging to details panel#302932
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR extends the chat debug “resolved event details” pipeline to support structured hook-execution details, enabling richer rendering in the debug details panel and exposing the new content type through the chatDebug proposed API.
Changes:
- Adds a new resolved content type for hook execution details (
hookType,command,input,output,result, timings, exit code, error message) and wires it through the ext host DTO/protocol. - Implements a dedicated browser renderer + plain-text conversion and integrates it into the debug detail panel.
- Updates the internal “resolve debug event details” tool formatting and bumps the
chatDebugproposal version.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatDebug.d.ts | Bumps proposal version and adds ChatDebugEventHookContent + union update. |
| src/vs/workbench/contrib/chat/common/tools/builtinTools/resolveDebugEventDetailsTool.ts | Adds plain-text formatting for resolved hook content. |
| src/vs/workbench/contrib/chat/common/chatDebugService.ts | Introduces internal IChatDebugEventHookContent and extends the resolved-content union. |
| src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugHookContentRenderer.ts | New UI renderer + plain-text conversion for hook content. |
| src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugDetailPanel.ts | Renders kind: 'hook' resolved content in the details panel. |
| src/vs/workbench/api/common/extHostTypes.ts | Adds ext host API class ChatDebugEventHookContent (with _kind). |
| src/vs/workbench/api/common/extHostChatDebug.ts | Serializes hookContent into the DTO (kind: 'hook'). |
| src/vs/workbench/api/common/extHost.protocol.ts | Adds IChatDebugEventHookContentDto and extends IChatDebugResolvedEventContentDto. |
| src/vs/workbench/api/common/extHost.api.impl.ts | Exposes ChatDebugEventHookContent on the API surface. |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Bumps chatDebug proposal version to 4. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugHookContentRenderer.ts
Show resolved
Hide resolved
|
/api-proposal-change-required |
See microsoft/vscode-copilot-chat#4336