Skip to content

Add hooks execution logging to details panel#302932

Merged
pwang347 merged 3 commits intomainfrom
pawang/logHooks
Mar 18, 2026
Merged

Add hooks execution logging to details panel#302932
pwang347 merged 3 commits intomainfrom
pawang/logHooks

Conversation

@pwang347
Copy link
Member

@pwang347 pwang347 commented Mar 18, 2026

Copilot AI review requested due to automatic review settings March 18, 2026 18:07
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

⚠️ API Proposal Version Change Detected

The following proposed API files have version changes: vscode.proposed.chatDebug.d.ts

API proposal version changes should only be used when maintaining compatibility is not possible. Consider keeping the version as is and maintaining backward compatibility.

Any version changes must be adopted by the consuming extensions before the next insiders for the extension to work.


If the version change is required, comment /api-proposal-change-required to unblock this check and acknowledge that you will update any critical consuming extensions (Copilot Chat).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the chat debug “resolved event details” pipeline to support structured hook-execution details, enabling richer rendering in the debug details panel and exposing the new content type through the chatDebug proposed API.

Changes:

  • Adds a new resolved content type for hook execution details (hookType, command, input, output, result, timings, exit code, error message) and wires it through the ext host DTO/protocol.
  • Implements a dedicated browser renderer + plain-text conversion and integrates it into the debug detail panel.
  • Updates the internal “resolve debug event details” tool formatting and bumps the chatDebug proposal version.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatDebug.d.ts Bumps proposal version and adds ChatDebugEventHookContent + union update.
src/vs/workbench/contrib/chat/common/tools/builtinTools/resolveDebugEventDetailsTool.ts Adds plain-text formatting for resolved hook content.
src/vs/workbench/contrib/chat/common/chatDebugService.ts Introduces internal IChatDebugEventHookContent and extends the resolved-content union.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugHookContentRenderer.ts New UI renderer + plain-text conversion for hook content.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugDetailPanel.ts Renders kind: 'hook' resolved content in the details panel.
src/vs/workbench/api/common/extHostTypes.ts Adds ext host API class ChatDebugEventHookContent (with _kind).
src/vs/workbench/api/common/extHostChatDebug.ts Serializes hookContent into the DTO (kind: 'hook').
src/vs/workbench/api/common/extHost.protocol.ts Adds IChatDebugEventHookContentDto and extends IChatDebugResolvedEventContentDto.
src/vs/workbench/api/common/extHost.api.impl.ts Exposes ChatDebugEventHookContent on the API surface.
src/vs/platform/extensions/common/extensionsApiProposals.ts Bumps chatDebug proposal version to 4.

You can also share your feedback on Copilot code review. Take the survey.

@pwang347
Copy link
Member Author

/api-proposal-change-required

@pwang347 pwang347 marked this pull request as ready for review March 18, 2026 18:59
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 18, 2026
@pwang347 pwang347 enabled auto-merge (squash) March 18, 2026 19:42
@pwang347 pwang347 merged commit 8e5c888 into main Mar 18, 2026
20 checks passed
@pwang347 pwang347 deleted the pawang/logHooks branch March 18, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants