Updating label to indicate a command executed in sandbox#303035
Merged
dileepyavan merged 6 commits intomainfrom Mar 19, 2026
Merged
Updating label to indicate a command executed in sandbox#303035dileepyavan merged 6 commits intomainfrom
dileepyavan merged 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates chat “Run in terminal” tool UI messaging to indicate when a command is executed via the terminal sandbox (lock icon + sandbox phrasing), aligning with issue #302913.
Changes:
- Add sandbox-aware invocation messaging in
RunInTerminalTool(lock icon + “Running in sandbox” variants). - Update chat terminal tool progress/collapsible header rendering to reflect sandbox wrapping.
- Add a unit test covering sandbox-wrapped invocation messaging/data.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts | Adds a test asserting sandbox invocation messaging and isSandboxWrapped propagation. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Switches the tool invocation message to sandbox-specific labels when isSandboxWrapped is true. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts | Passes sandbox state into the collapsible wrapper and renders a lock icon label for sandbox runs. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts
Show resolved
Hide resolved
...rib/chat/browser/widget/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Outdated
Show resolved
Hide resolved
...rib/chat/browser/widget/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Outdated
Show resolved
Hide resolved
...bench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts
Show resolved
Hide resolved
alexdima
previously approved these changes
Mar 19, 2026
alexdima
previously approved these changes
Mar 19, 2026
alexdima
approved these changes
Mar 19, 2026
bpasero
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #302913