Skip to content

Submit active session feedback action and CI check improvements#303336

Merged
benibenj merged 1 commit intomainfrom
benibenj/experimental-weasel
Mar 20, 2026
Merged

Submit active session feedback action and CI check improvements#303336
benibenj merged 1 commit intomainfrom
benibenj/experimental-weasel

Conversation

@benibenj
Copy link
Contributor

Copilot Generated Description: Introduce a new action to submit feedback for the currently active session. Update the context key for active session feedback and register the action in the menu. Additionally, refactor CI check handling by removing redundant functions and integrating new check handling logic.

Copilot AI review requested due to automatic review settings March 19, 2026 22:54
@benibenj benibenj enabled auto-merge March 19, 2026 22:54
@benibenj benibenj self-assigned this Mar 19, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds sessions-window actions to (1) prompt the chat to fix failed CI checks for the active session and (2) submit pending agent feedback for the active session, wiring both into context keys/menus to appear only when relevant.

Changes:

  • Introduces Fix CI Checks action + active-session failed-checks context key.
  • Refactors CI check helper logic to be shared between the CI status widget and the new action.
  • Adds Submit Feedback action for the active session and dynamically registers a menu item showing the pending feedback count.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/vs/sessions/contrib/changes/browser/fixCIChecksAction.ts New action + context contribution for failed CI checks; also exports CI helper utilities.
src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts Reuses CI helper utilities from the new module instead of local implementations.
src/vs/sessions/contrib/changes/browser/changesView.contribution.ts Ensures the new CI checks action module is loaded/registered.
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorActions.ts Adds active-session feedback context key + new submit action.
src/vs/sessions/contrib/agentFeedback/browser/agentFeedback.contribution.ts Adds a workbench contribution to maintain the active-session feedback context key and register a counted menu item.

@benibenj benibenj closed this Mar 20, 2026
auto-merge was automatically disabled March 20, 2026 09:11

Pull request was closed

@benibenj benibenj reopened this Mar 20, 2026
@benibenj benibenj merged commit 74054b8 into main Mar 20, 2026
38 checks passed
@benibenj benibenj deleted the benibenj/experimental-weasel branch March 20, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants