Submit active session feedback action and CI check improvements#303336
Merged
Submit active session feedback action and CI check improvements#303336
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds sessions-window actions to (1) prompt the chat to fix failed CI checks for the active session and (2) submit pending agent feedback for the active session, wiring both into context keys/menus to appear only when relevant.
Changes:
- Introduces
Fix CI Checksaction + active-session failed-checks context key. - Refactors CI check helper logic to be shared between the CI status widget and the new action.
- Adds
Submit Feedbackaction for the active session and dynamically registers a menu item showing the pending feedback count.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/browser/fixCIChecksAction.ts | New action + context contribution for failed CI checks; also exports CI helper utilities. |
| src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts | Reuses CI helper utilities from the new module instead of local implementations. |
| src/vs/sessions/contrib/changes/browser/changesView.contribution.ts | Ensures the new CI checks action module is loaded/registered. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorActions.ts | Adds active-session feedback context key + new submit action. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedback.contribution.ts | Adds a workbench contribution to maintain the active-session feedback context key and register a counted menu item. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorActions.ts
Show resolved
Hide resolved
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorActions.ts
Show resolved
Hide resolved
jrieken
approved these changes
Mar 20, 2026
auto-merge was automatically disabled
March 20, 2026 09:11
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a new action to submit feedback for the currently active session. Update the context key for active session feedback and register the action in the menu. Additionally, refactor CI check handling by removing redundant functions and integrating new check handling logic.