inlineChat: shared history service with persistence#303471
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a shared, persistent inline chat input history so all InlineChatInputWidget instances reuse the same history and it survives reloads.
Changes:
- Added
InlineChatHistoryServicewithHistoryNavigator2<string>and profile-scoped persistence viaIStorageService. - Updated
InlineChatInputWidgetto delegate history navigation/state toIInlineChatHistoryServiceinstead of a per-widget navigator. - Registered the new history service as a delayed singleton in
inlineChat.contribution.ts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts | Switches history handling from per-widget HistoryNavigator2 to injected shared history service. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatHistoryService.ts | New service that restores/saves inline chat input history to profile storage. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChat.contribution.ts | Registers IInlineChatHistoryService as a delayed singleton. |
hediet
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
IInlineChatHistoryServiceso that allInlineChatInputWidgetinstances share one history and that history survives reloads.What changed
New
InlineChatHistoryService(inlineChatHistoryService.ts)HistoryNavigator2<string>instanceIStorageServiceunderStorageScope.PROFILE(survives reloads, shared across windows of the same profile)onWillSaveStateUpdated
InlineChatInputWidget- removed the per-instance_historyNavigatorfield and injectsIInlineChatHistoryServiceinstead, delegating all history operations to itRegistered the service as a delayed singleton in
inlineChat.contribution.tsWhy
Previously each
InlineChatInputWidgetinstance had its ownHistoryNavigator2, so history was not shared across editors and was lost on reload. Now a single service owns the history, making it consistent everywhere and persistent.