refactor: rename image carousel configuration and update related descriptions#303630
Merged
TylerLeonhardt merged 3 commits intomainfrom Mar 20, 2026
Merged
refactor: rename image carousel configuration and update related descriptions#303630TylerLeonhardt merged 3 commits intomainfrom
TylerLeonhardt merged 3 commits intomainfrom
Conversation
…riptions also make default true
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames and reorganizes the image carousel enablement setting used by chat, and updates related user-facing labels/descriptions to use the new “Show Images” / “Images Preview” wording.
Changes:
- Move the chat image-carousel enablement setting from
chat.imageCarousel.enabledtoimageCarousel.chat.enabledand register it under theimageCarouselconfiguration section. - Update editor pane and command/menu titles from “Image Carousel” / “Open …” to “Images Preview” / “Show Images”.
- Enable the Explorer context-menu entry by default via
imageCarousel.explorerContextMenu.enabled: true.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/imageCarousel/browser/imageCarousel.contribution.ts | Adds imageCarousel.chat.enabled, flips Explorer context-menu default to true, and updates UI strings to “Show Images” / “Images Preview”. |
| src/vs/workbench/contrib/chat/common/constants.ts | Points ChatConfiguration.ImageCarouselEnabled at the new imageCarousel.chat.enabled key. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Removes the old chat.imageCarousel.enabled configuration registration. |
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/chat.contribution.ts:506
- The setting key was renamed from
chat.imageCarousel.enabledtoimageCarousel.chat.enabledand the old schema entry was removed, but there is no configuration migration registered to preserve existing user/workspace settings. Add aregisterConfigurationMigrationsentry that moves any existingchat.imageCarousel.enabledvalues over to the new key (and ideally clears the old key), so users don’t silently lose their configuration after upgrading.
type: 'boolean',
tags: ['experimental']
},
[ChatConfiguration.ArtifactsEnabled]: {
default: false,
description: nls.localize('chat.artifacts.enabled', "Controls whether the artifacts view is available in chat."),
type: 'boolean',
tags: ['experimental']
src/vs/workbench/contrib/imageCarousel/browser/imageCarousel.contribution.ts
Show resolved
Hide resolved
mjbvz
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also make default true