select model when sub menu value is selected#304172
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the ActionWidget action list submenu behavior and styling to improve model-picker submenu interactions (notably around “Thinking/Reasoning effort”), addressing the reported model picker dismissal/interaction issues.
Changes:
- Switch submenu activation from chevron hover/click to row hover (with a delay) and adjust submenu anchoring/positioning to avoid overlap issues.
- When a submenu action is selected, also select the parent item in the main list (so submenu changes don’t effectively “drop” the parent selection flow).
- Tweak action widget row/filter spacing and submenu-indicator styling to reduce visual overlap and improve layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/platform/actionWidget/browser/actionWidget.css | Adjusts row/filter spacing and submenu-indicator styling to reduce overlap and improve alignment. |
| src/vs/platform/actionWidget/browser/actionList.ts | Changes submenu trigger mechanics (row-hover + delay), positions submenu relative to the row, and selects the parent item when a submenu action is chosen. |
Comments suppressed due to low confidence (1)
src/vs/platform/actionWidget/browser/actionList.ts:1420
- With the removal of the submenu-indicator click/hover wiring, clicking on the chevron area no longer opens the submenu, and selection is still suppressed for clicks targeting
.action-list-submenu-indicator(seeonListSelection). This makes a click on the indicator effectively a no-op. Consider either reintroducing an explicit click handler to open the submenu immediately, or removing/relaxing the selection-suppression for indicator clicks now that the indicator is not interactive.
private onListClick(e: IListMouseEvent<IActionListItem<T>>): void {
if (e.element && e.element.isSectionToggle && e.element.section) {
const section = e.element.section;
queueMicrotask(() => this._toggleSection(section));
return;
}
if (e.element && this.focusCondition(e.element)) {
this._list.setFocus([]);
}
dmitrivMS
approved these changes
Mar 23, 2026
sandy081
added a commit
that referenced
this pull request
Mar 23, 2026
* model picker feedback fixes * fix alignment * select model when sub menu value is selected * feedback
sandy081
added a commit
that referenced
this pull request
Mar 23, 2026
select model when sub menu value is selected (#304172) * model picker feedback fixes * fix alignment * select model when sub menu value is selected * feedback
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
#304120
#303570
#304017