Skip to content

select model when sub menu value is selected#304172

Merged
sandy081 merged 4 commits intomainfrom
sandy081/shivering-wildfowl
Mar 23, 2026
Merged

select model when sub menu value is selected#304172
sandy081 merged 4 commits intomainfrom
sandy081/shivering-wildfowl

Conversation

@sandy081
Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings March 23, 2026 17:19
@sandy081 sandy081 enabled auto-merge (squash) March 23, 2026 17:19
@sandy081 sandy081 self-assigned this Mar 23, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.114.0 milestone Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the ActionWidget action list submenu behavior and styling to improve model-picker submenu interactions (notably around “Thinking/Reasoning effort”), addressing the reported model picker dismissal/interaction issues.

Changes:

  • Switch submenu activation from chevron hover/click to row hover (with a delay) and adjust submenu anchoring/positioning to avoid overlap issues.
  • When a submenu action is selected, also select the parent item in the main list (so submenu changes don’t effectively “drop” the parent selection flow).
  • Tweak action widget row/filter spacing and submenu-indicator styling to reduce visual overlap and improve layout.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/platform/actionWidget/browser/actionWidget.css Adjusts row/filter spacing and submenu-indicator styling to reduce overlap and improve alignment.
src/vs/platform/actionWidget/browser/actionList.ts Changes submenu trigger mechanics (row-hover + delay), positions submenu relative to the row, and selects the parent item when a submenu action is chosen.
Comments suppressed due to low confidence (1)

src/vs/platform/actionWidget/browser/actionList.ts:1420

  • With the removal of the submenu-indicator click/hover wiring, clicking on the chevron area no longer opens the submenu, and selection is still suppressed for clicks targeting .action-list-submenu-indicator (see onListSelection). This makes a click on the indicator effectively a no-op. Consider either reintroducing an explicit click handler to open the submenu immediately, or removing/relaxing the selection-suppression for indicator clicks now that the indicator is not interactive.
	private onListClick(e: IListMouseEvent<IActionListItem<T>>): void {
		if (e.element && e.element.isSectionToggle && e.element.section) {
			const section = e.element.section;
			queueMicrotask(() => this._toggleSection(section));
			return;
		}
		if (e.element && this.focusCondition(e.element)) {
			this._list.setFocus([]);
		}

Comment thread src/vs/platform/actionWidget/browser/actionList.ts
@sandy081 sandy081 merged commit fb7273f into main Mar 23, 2026
19 checks passed
@sandy081 sandy081 deleted the sandy081/shivering-wildfowl branch March 23, 2026 18:02
sandy081 added a commit that referenced this pull request Mar 23, 2026
* model picker feedback fixes

* fix alignment

* select model when sub menu value is selected

* feedback
sandy081 added a commit that referenced this pull request Mar 23, 2026
select model when sub menu value is selected (#304172)

* model picker feedback fixes

* fix alignment

* select model when sub menu value is selected

* feedback
@eli-w-king eli-w-king mentioned this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants