Make sure update tooltip is updated in all windows, not just focused one#304177
Merged
Make sure update tooltip is updated in all windows, not just focused one#304177
Conversation
dmitrivMS
added
the
install-update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes stale Update title-bar tooltip content in multi-window scenarios by ensuring the tooltip state is refreshed even when the window is not the last-focused one, addressing the “Up to Date” tooltip being shown while an update is actually available.
Changes:
- Separates the
mode === 'none'early return from the focus/visibility guard. - Renders the tooltip state when the tooltip is visible or when the window was not last focused (instead of returning without updating).
- Keeps auto-show tooltip behavior gated to the last-focused window.
rzhao271
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302951