Skip to content

fixes window.title#304235

Merged
eli-w-king merged 2 commits intorelease/1.113from
eli/compact-rev2
Mar 23, 2026
Merged

fixes window.title#304235
eli-w-king merged 2 commits intorelease/1.113from
eli/compact-rev2

Conversation

@eli-w-king
Copy link
Copy Markdown
Contributor

@eli-w-king eli-w-king commented Mar 23, 2026

fixes #303429

Steps to repro:

  1. Set agent status to compact if it is not already
  2. Change window.title to ${rootName} - ${activeRepositoryBranchName} then ${activeRepositoryName}${separator}${activeFolderMedium}
  3. Correct title should show in command center placeholder text

@eli-w-king eli-w-king self-assigned this Mar 23, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.112.1 milestone Mar 23, 2026
@eli-w-king eli-w-king requested a review from joshspicer March 23, 2026 19:22
@eli-w-king eli-w-king modified the milestones: 1.112.1, 1.113.0 Mar 23, 2026
@eli-w-king eli-w-king added candidate Issue identified as probable candidate for fixing in the next release command-center labels Mar 23, 2026
@eli-w-king eli-w-king marked this pull request as ready for review March 23, 2026 19:22
@eli-w-king eli-w-king requested a review from sbatten March 23, 2026 19:22
@eli-w-king eli-w-king enabled auto-merge March 23, 2026 20:14
@sbatten
Copy link
Copy Markdown
Member

sbatten commented Mar 23, 2026

I think this if fine for a candidate fix, but it seems like this data should flow through the titleService

@eli-w-king eli-w-king merged commit 2dec0ac into release/1.113 Mar 23, 2026
19 checks passed
@eli-w-king eli-w-king deleted the eli/compact-rev2 branch March 23, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

candidate Issue identified as probable candidate for fixing in the next release command-center

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants