Conversation
…chat res…" This reverts commit 29359ef.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts prior work that added absolute file path details for inline references in the Chat Response Accessible View, likely to avoid exposing full paths in accessibility/plaintext output.
Changes:
- Removes the
inlineReferencerendering branch fromChatResponseAccessibleView’s accessible-view content generation. - Drops tests that asserted accessible-view output includes inline reference file paths (and line numbers / basenames).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/accessibility/chatResponseAccessibleView.ts |
Removes inline-reference-to-text conversion (previously included paths) from accessible view output. |
src/vs/workbench/contrib/chat/test/browser/accessibility/chatResponseAccessibleView.test.ts |
Removes coverage asserting inline reference paths/locations are present in accessible view output. |
src/vs/workbench/contrib/chat/browser/accessibility/chatResponseAccessibleView.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/accessibility/chatResponseAccessibleView.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/test/browser/accessibility/chatResponseAccessibleView.test.ts
Show resolved
Hide resolved
roblourens
approved these changes
Mar 24, 2026
alexdima
deleted the
revert-301565-copilot/add-file-paths-to-accessible-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #301565