sessions: polish run task quick input modal#304652
Merged
hawkticehurst merged 41 commits intomainfrom Mar 30, 2026
Merged
Conversation
… and improve padding
…ight, and add new button styles
…, padding, and gap for improved UI consistency
… add new titlebar styles for improved UI consistency
…ction for improved UI consistency
…d layout consistency
…et for improved UI consistency
…d colors for improved UI consistency
…widget; refine localization strings for clarity
…widget for improved visual consistency
…widget for improved visual consistency
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Polishes the Agent Sessions Run Task quick input modal to look and behave more like a consistent modal surface in the sessions window.
Changes:
- Added a titlebar close button to the run-task quick widget and wired it into the existing cancel/hide flow.
- Refined spacing/layout and control styling for the run-task widget, including segmented radio and button sizing/alignment.
- Adjusted quick input styling and documented the change in
src/vs/sessions/LAYOUT.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/chat/browser/runScriptAction.ts | Adds a close button to the run-task quick widget and updates run-task strings/copy. |
| src/vs/sessions/contrib/chat/browser/media/runScriptAction.css | Styles the run-task widget and scopes titlebar tweaks via a marker class on the quick input widget. |
| src/vs/platform/quickinput/browser/media/quickInput.css | Updates shared quick input CSS (rounding/overflow and spacing). |
| src/vs/sessions/LAYOUT.md | Records the modal polish change in the sessions layout revision history. |
…ns and improve hint display
…ce custom command input functionality
… margin styles in run-script-action widget
# Conflicts: # src/vs/sessions/contrib/chat/browser/runScriptAction.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tActionViewItem" This reverts commit a7b7a0d.
This reverts commit 0b2e44b.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts: # src/vs/sessions/LAYOUT.md
# Conflicts: # src/vs/sessions/LAYOUT.md # src/vs/sessions/contrib/chat/browser/runScriptAction.ts
… target lock state
joshspicer
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polishes the Agent Sessions Run Task quick input modal for a cleaner, more consistent modal experience while keeping changes scoped to this surface.
What changed
run-script-action-quick-widget) so other quick input widgets keep default behavior.Create new task)src/vs/sessions/LAYOUT.mdrevision history with the modal polish note.Files touched
src/vs/sessions/contrib/chat/browser/runScriptAction.tssrc/vs/sessions/contrib/chat/browser/media/runScriptAction.csssrc/vs/platform/quickinput/browser/media/quickInput.csssrc/vs/sessions/LAYOUT.mdValidation
npm run compile-check-ts-nativenpm run hygienecurrently fails due to a pre-existing/generated-file issue:extensions/mermaid-chat-features/chat-webview-out/codicon.css: Missing or bad copyright statementThis hygiene failure is outside the scoped modal changes above.
Screenshots