Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tweaks run_in_terminal execution behavior and related configuration/test plumbing in VS Code’s terminal + chat agent tools, likely aiming to address recent integration test failures and stabilize tool output capture.
Changes:
- Adjust
RichExecuteStrategyoutput handling by removing command/prompt stripping logic. - Reduce a cursor-move wait timeout in
NoneExecuteStrategy. - Introduce a
terminal.integrated.shellIntegration.timeout = -2sentinel (treated as0) and update the API test to use it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/richExecuteStrategy.ts | Changes how rich shell-integration output is post-processed before returning tool results. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/noneExecuteStrategy.ts | Tightens the cursor-move waiting timeout before idle detection. |
| src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts | Adds special-case handling for shellIntegration.timeout = -2 (test sentinel). |
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Expands the allowed range for the setting to include -2 and updates its description. |
| extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts | Updates the integration test to set shellIntegration.timeout to -2. |
...kbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/richExecuteStrategy.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts
Outdated
Show resolved
Hide resolved
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts
Outdated
Show resolved
Hide resolved
alexdima
reviewed
Mar 25, 2026
meganrogge
commented
Mar 25, 2026
Tyriar
previously requested changes
Mar 25, 2026
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts
Outdated
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alexdima