Skip to content

tweak run_in_terminal changes#304843

Merged
meganrogge merged 9 commits intomainfrom
merogge/tweak-run-terminal
Mar 26, 2026
Merged

tweak run_in_terminal changes#304843
meganrogge merged 9 commits intomainfrom
merogge/tweak-run-terminal

Conversation

@meganrogge
Copy link
Collaborator

Copilot AI review requested due to automatic review settings March 25, 2026 18:06
@meganrogge meganrogge self-assigned this Mar 25, 2026
@meganrogge meganrogge requested a review from Tyriar March 25, 2026 18:06
@meganrogge meganrogge added this to the 1.114.0 milestone Mar 25, 2026
@meganrogge meganrogge enabled auto-merge (squash) March 25, 2026 18:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tweaks run_in_terminal execution behavior and related configuration/test plumbing in VS Code’s terminal + chat agent tools, likely aiming to address recent integration test failures and stabilize tool output capture.

Changes:

  • Adjust RichExecuteStrategy output handling by removing command/prompt stripping logic.
  • Reduce a cursor-move wait timeout in NoneExecuteStrategy.
  • Introduce a terminal.integrated.shellIntegration.timeout = -2 sentinel (treated as 0) and update the API test to use it.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/richExecuteStrategy.ts Changes how rich shell-integration output is post-processed before returning tool results.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/noneExecuteStrategy.ts Tightens the cursor-move waiting timeout before idle detection.
src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts Adds special-case handling for shellIntegration.timeout = -2 (test sentinel).
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts Expands the allowed range for the setting to include -2 and updates its description.
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts Updates the integration test to set shellIntegration.timeout to -2.

Tyriar
Tyriar previously requested changes Mar 25, 2026
@meganrogge meganrogge merged commit c4f707a into main Mar 26, 2026
18 checks passed
@meganrogge meganrogge deleted the merogge/tweak-run-terminal branch March 26, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants