fix: make testing icon colors inherit from list error/warning foreground#304959
Merged
connor4312 merged 3 commits intomicrosoft:mainfrom Mar 27, 2026
Merged
Conversation
Make testing.iconFailed and testing.iconErrored inherit from list.errorForeground, and testing.iconQueued inherit from list.warningForeground, so that test explorer icons are consistent with the rest of the list widget error and warning styling. Closes microsoft#252993
connor4312
approved these changes
Mar 26, 2026
dmitrivMS
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Polish / debt reduction
What is the current behavior?
The testing icon colors (
testing.iconFailed,testing.iconErrored,testing.iconQueued) use hardcoded color values that don't match the semantic color tokens used elsewhere in the list widget. For example,testing.iconFaileduses#f14c4cwhilelist.errorForegrounduses#F88070(dark) /#B01011(light).Closes #252993
What is the new behavior?
testing.iconFailednow inherits fromlist.errorForegroundtesting.iconErrorednow inherits fromlist.errorForegroundtesting.iconQueuednow inherits fromlist.warningForegroundThis ensures that test explorer icons are visually consistent with the error and warning styling used by other list widgets (e.g., problems panel, outline view).
Users who have customized these colors in their
settings.jsonwill not be affected since explicit overrides take precedence over the default inheritance.Additional context
Single-file change in
src/vs/workbench/contrib/testing/browser/theme.ts. TypeScript compilation passes with no errors.