Add isSandbox field to runInTerminal telemetry#305127
Merged
Conversation
Reports whether the command was run inside the terminal sandbox (0 | 1). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds terminal sandbox execution attribution to the toolUse.runInTerminal telemetry so usage can be segmented by whether a command ran inside the terminal sandbox.
Changes:
- Adds
isSandbox(0|1) to thetoolUse.runInTerminaltelemetry event payload and classification. - Wires an
isSandboxWrappedflag fromRunInTerminalToolinvocation state into telemetry mapping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts |
Adds isSandboxWrapped to the telemetry state passed on invocation completion. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalToolTelemetry.ts |
Extends the telemetry schema/classification with isSandbox and maps it from the invocation state. |
bpasero
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
isSandbox(0 | 1) to thetoolUse.runInTerminaltelemetry event to track whether commands run inside the terminal sandbox.