Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts CIStatusWidget’s layout behavior in the Agent Sessions Changes view, aiming to simplify height handling for the CI checks list.
Changes:
- Simplified
CIStatusWidget.layout(...)to directly lay out the underlying list using the provided height. - Removed internal height clamping and explicit
style.heightassignments from bothlayout(...)and_renderBody(...).
| layout(height: number): void { | ||
| this._list.layout(height); | ||
| } |
There was a problem hiding this comment.
CIStatusWidget.layout now forwards the computed height into this._list.layout(height) but no longer synchronizes the list element’s actual DOM height with that value. Because the widget’s body height is currently determined by flex layout (and the header’s real height can differ from CIStatusWidget.HEADER_HEIGHT), the list viewport height used for scrolling/rendering can drift from the element’s real clientHeight, leading to incorrect scrolling/blank space/clipping. Consider either setting the list element height to height here (as before), or calling this._list.layout() without a height so it measures the actual DOM size, or aligning the header CSS to the constant so the computed height matches reality.
Copilot Generated Description:Adjust the layout method in the CIStatusWidget to simplify height handling and remove unnecessary calculations.