Skip to content

Fix CI widget layout#305661

Merged
benibenj merged 1 commit intomainfrom
benibenj/planned-haddock
Mar 27, 2026
Merged

Fix CI widget layout#305661
benibenj merged 1 commit intomainfrom
benibenj/planned-haddock

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

Copilot Generated Description: Adjust the layout method in the CIStatusWidget to simplify height handling and remove unnecessary calculations.

Copilot AI review requested due to automatic review settings March 27, 2026 14:03
@benibenj benibenj enabled auto-merge March 27, 2026 14:03
@benibenj benibenj self-assigned this Mar 27, 2026
@vs-code-engineering vs-code-engineering bot added this to the Backlog milestone Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts CIStatusWidget’s layout behavior in the Agent Sessions Changes view, aiming to simplify height handling for the CI checks list.

Changes:

  • Simplified CIStatusWidget.layout(...) to directly lay out the underlying list using the provided height.
  • Removed internal height clamping and explicit style.height assignments from both layout(...) and _renderBody(...).

Comment on lines +333 to 335
layout(height: number): void {
this._list.layout(height);
}
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIStatusWidget.layout now forwards the computed height into this._list.layout(height) but no longer synchronizes the list element’s actual DOM height with that value. Because the widget’s body height is currently determined by flex layout (and the header’s real height can differ from CIStatusWidget.HEADER_HEIGHT), the list viewport height used for scrolling/rendering can drift from the element’s real clientHeight, leading to incorrect scrolling/blank space/clipping. Consider either setting the list element height to height here (as before), or calling this._list.layout() without a height so it measures the actual DOM size, or aligning the header CSS to the constant so the computed height matches reality.

Copilot uses AI. Check for mistakes.
@benibenj benibenj merged commit 93cc2b1 into main Mar 27, 2026
32 of 33 checks passed
@benibenj benibenj deleted the benibenj/planned-haddock branch March 27, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants