sessions: fix multi-select context menu to operate on all selected items#306332
Merged
sessions: fix multi-select context menu to operate on all selected items#306332
Conversation
Context menu actions in the sessions list previously only operated on the right-clicked item, ignoring other selected items. Now the context menu collects the tree selection and passes all selected sessions to actions. Changes: - sessionsList.ts: Pass selected sessions array as arg to context menu actions - sessionsViewActions.ts: Update all 7 item actions to accept ISession | ISession[] - copilotChatSessionsActions.ts: Update bridge commands to handle session arrays Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bpasero
previously approved these changes
Mar 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes multi-select behavior in the Agent Sessions list context menu so actions apply to all selected sessions (instead of only the right-clicked row), including Copilot-bridged menu items.
Changes:
- Update sessions list context menu to pass the full selected session set as the menu argument.
- Update session item actions (pin/archive/read/open) to accept
ISession | ISession[]and iterate over all sessions. - Update Copilot context menu bridge commands to support
ISession[]by resolving and marshalling multiple agent sessions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts | Session item actions now accept single-or-array context and apply operations across the selection. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts | Context menu now derives and forwards the current multi-selection (filtered to session items). |
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsActions.ts | Copilot context menu bridge wrapper commands now handle array context and marshal multiple agent sessions. |
| } | ||
|
|
||
| const selection = this.tree.getSelection().filter((s): s is ISession => !!s && !isSessionSection(s) && !isSessionShowMore(s)); | ||
| const selectedSessions = selection.includes(element) ? selection : [element]; |
There was a problem hiding this comment.
When multi-selecting, selectedSessions uses the tree selection array as-is. That array’s order isn’t guaranteed to have the right-clicked element first, but downstream commands often treat the first item as the “primary”/clicked item. Consider ensuring element is first (e.g., [element, ...selection.filter(s => s !== element)]) or passing a structured context that preserves both the clicked item and the full selection.
Suggested change
| const selectedSessions = selection.includes(element) ? selection : [element]; | |
| const selectedSessions = selection.includes(element) ? [element, ...selection.filter(s => s !== element)] : [element]; |
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsActions.ts
Show resolved
Hide resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lszomoru
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context menu actions in the sessions list only operated on the right-clicked item, ignoring other selected items in a multi-selection.
Changes
sessionsList.tsgetSelection()and filter toISessionitemsargto context menu actionssessionsViewActions.tsISession | ISession[]and iterate over all provided sessionscopilotChatSessionsActions.tsCopilotSessionContextMenuBridgewrapper commands to handleISession[]— resolves all sessions to agent sessions and passes them in the marshalled context