Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances chat setup diagnostics by centralizing timeout telemetry/log payload computation and adding new logging/telemetry for cases where chat setup eventually becomes ready after an initial timeout.
Changes:
- Refactors timeout diagnostics into a shared
computeDiagnosticInfo(...)helper to reuse for both logging and telemetry. - Introduces a new
chatSetup.timeoutRecoverytelemetry event (and accompanying info log) after readiness signals complete post-timeout. - Adjusts readiness waiting logic to reuse a single
allReadyPromise.allSettled(...)across the timeout race and subsequent recovery handling.
src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupProviders.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupProviders.ts
Outdated
Show resolved
Hide resolved
chrmarti
force-pushed
the
chrmarti/melted-kingfisher
branch
from
e2a6d69 to
6049dc4
Compare
anthonykim1
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.