remove shell integration none tests#306932
Merged
meganrogge merged 3 commits intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the “shell integration: none” variant of the run_in_terminal API tests due to flakiness, leaving the suite focused on the expected (shell integration enabled) behavior and sandbox behavior.
Changes:
- Deleted the “shell integration off” test suite and related configuration overrides (including the timeout override enum and idle polling tweak).
- Flattened the remaining tests so the “sandbox off” cases run without the
defineTests(hasShellIntegration)indirection. - Tightened several assertions to no longer allow the shell-integration-disabled fallback outputs.
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts
Show resolved
Hide resolved
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts
Outdated
Show resolved
Hide resolved
…erminal.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rzhao271
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are flaky because shell integration: none can be flaky. We push users to enable shell integration and the vast majority have it.