Skip to content

Sessions - 💄 more cleanup#307028

Merged
lszomoru merged 2 commits intomainfrom
lszomoru/tasteless-swallow
Apr 1, 2026
Merged

Sessions - 💄 more cleanup#307028
lszomoru merged 2 commits intomainfrom
lszomoru/tasteless-swallow

Conversation

@lszomoru
Copy link
Copy Markdown
Member

@lszomoru lszomoru commented Apr 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 1, 2026 05:53
@lszomoru lszomoru enabled auto-merge (squash) April 1, 2026 05:53
@lszomoru lszomoru self-assigned this Apr 1, 2026
@lszomoru lszomoru added this to the 1.115.0 milestone Apr 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues cleanup work in the Sessions “Changes” UI by moving git-diff observable construction out of the ChangesViewPane and into the ChangesViewModel, reducing view-layer duplication and centralizing active-session diff state.

Changes:

  • Introduces activeSessionAllChangesObs and activeSessionLastTurnChangesObs on ChangesViewModel.
  • Removes the equivalent allChangesObs / lastTurnChangesObs derived observables from ChangesViewPane and switches the view to consume the model’s observables.

@lszomoru lszomoru marked this pull request as draft April 1, 2026 05:59
auto-merge was automatically disabled April 1, 2026 05:59

Pull request was converted to draft

@lszomoru lszomoru merged commit 548f6c2 into main Apr 1, 2026
28 of 29 checks passed
@lszomoru lszomoru deleted the lszomoru/tasteless-swallow branch April 1, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants