Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VS Code API test suite to reduce CI flakiness by disabling additional run_in_terminal assertions in the chat tool tests.
Changes:
- Skips the “echo command returns exactly the echoed text” test in the
sandbox offsuite. - Skips the “multi-line output preserves all lines in order” test in the
sandbox offsuite.
Comments suppressed due to low confidence (1)
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts:209
- This test is now skipped without any context on what makes it flaky or a link to a tracking issue. Please add a brief note (preferably with a GitHub issue/number) so there is an owner and a clear path to re-enable the test.
test.skip('multi-line output preserves all lines in order', async function () {
this.timeout(60000);
extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts
Show resolved
Hide resolved
bpasero
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.