clean up chat copilot session handling by removing unused agent options#307307
Merged
DonJayamanne merged 1 commit intomainfrom Apr 2, 2026
Merged
clean up chat copilot session handling by removing unused agent options#307307DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies chat session state handling by removing the legacy “agent” session option plumbing and an experimental extension-point flag for populating built-in pickers, consolidating restoration behavior around request history / transferred input state.
Changes:
- Remove
useRequestToPopulateBuiltInPickersfromIChatSessionsExtensionPointand delete the exportedagentOptionIdconstant. - Always derive initial remote-session input state (mode/model) from the last request’s
modelId/modeInstructionswhen present (no longer gated by an extension-point flag). - Delete
ChatInputPartlogic that synchronized the current mode to a session option and restored mode from the'agent'session option.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/chatSessionsService.ts |
Removes the experimental extension option and the shared 'agent' option ID constant. |
src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts |
Removes conditional gating and always uses request history to seed remote session input state when possible. |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts |
Removes reading/writing the agent selection via session options. |
dmitrivMS
approved these changes
Apr 2, 2026
Contributor
Author
|
@mjbvz /cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.