chore: use protocol from product configuration for openAgentsWindow action#307585
Merged
deepak1556 merged 3 commits intomainfrom Apr 3, 2026
Merged
chore: use protocol from product configuration for openAgentsWindow action#307585deepak1556 merged 3 commits intomainfrom
deepak1556 merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Open Agents Application” command to derive the external URL protocol from product configuration (instead of hardcoding a quality→scheme mapping), and extends the product configuration typing to support this embedded-app metadata.
Changes:
- Switch
OpenAgentsWindowActionto open the external Agents app usingproductService.embedded.urlProtocolwhen available. - Add
embedded?: IEmbeddedProductConfigurationtoIProductConfigurationand define the new embedded configuration interface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts |
Uses the embedded product config’s protocol to open the external Agents app (with fallback to nativeHostService.openAgentsWindow()). |
src/vs/base/common/product.ts |
Adds a new embedded section to product configuration typings, including the embedded app’s protocol and platform identifiers. |
src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts
Show resolved
Hide resolved
bhavyaus
previously approved these changes
Apr 3, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bhavyaus
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.