feat: add plugins to chatPromptFiles API#307669
Merged
joshspicer merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the proposed chatPromptFiles API surface to let extensions discover installed agent plugins by wiring IAgentPluginService.plugins from the main thread into the extension host, alongside existing custom agents/instructions/skills resources.
Changes:
- Added
ChatPluginResourcepluschat.pluginsandchat.onDidChangePluginsto thechatPromptFilesproposed API. - Extended the ext host RPC protocol with
IPluginDtoand$acceptPlugins(...), and implemented storage/events inExtHostChatAgents2. - Pushed plugin updates from
MainThreadChatAgents2via anautorunoverIAgentPluginService.plugins(and injectedIAgentPluginService).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatPromptFiles.d.ts | Adds the proposed API typings for plugin resources and change notification. |
| src/vs/workbench/api/common/extHostChatAgents2.ts | Stores plugin list in the ext host and raises onDidChangePlugins when updated by the main thread. |
| src/vs/workbench/api/common/extHost.protocol.ts | Adds IPluginDto and $acceptPlugins to the ext host shape for main-thread-to-ext-host updates. |
| src/vs/workbench/api/common/extHost.api.impl.ts | Exposes vscode.chat.plugins and vscode.chat.onDidChangePlugins behind chatPromptFiles proposal gating. |
| src/vs/workbench/api/browser/mainThreadChatAgents2.ts | Observes IAgentPluginService.plugins and pushes DTOs to the ext host reactively. |
joshspicer
force-pushed
the
josh/plugins-chatpromptfiles-api
branch
from
ea415f3 to
fb6c6f8
Compare
Wire installed agent plugins through the chatPromptFiles proposed API: - Add ChatPluginResource interface with uri + label - Add chat.plugins getter and chat.onDidChangePlugins event - Add IPluginDto and $acceptPlugins to ext host protocol - Push plugins from mainThread via autorun on IAgentPluginService - Inject IAgentPluginService into MainThreadChatAgents2
joshspicer
force-pushed
the
josh/plugins-chatpromptfiles-api
branch
from
fb6c6f8 to
165f4a2
Compare
vijayupadya
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire installed agent plugins through the chatPromptFiles proposed API so extensions can discover them.
Changes
chat.pluginsreadonly getter andchat.onDidChangePluginsevent (uses existingChatResourcetype)IPluginDtoto ext host protocolautorunonIAgentPluginService.pluginsobservableIAgentPluginServiceintoMainThreadChatAgents2Companion PR: microsoft/vscode-copilot-chat#4962