agentHost: Validate strings in bash commands#307699
Merged
roblourens merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
connor4312
approved these changes
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens command construction in the SSH remote agent-host bootstrap flow by validating productService.quality before using it in unquoted shell paths, and by consistently shell-escaping the CLI download URL.
Changes:
- Add a
validateShellTokenhelper to ensurequalityis safe to interpolate into unquoted shell path segments. - Route
getRemoteCLIDir/getRemoteCLIBinthrough the validation helper. - Use
shellEscape(url)when building the remotecurl | tarinstall command.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/sshRemoteAgentHostService.ts | Validates quality for safe shell interpolation and strengthens URL escaping in the remote CLI install command. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com