Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Sessions (Agents window) telemetry for the “Run” split-button dropdown by ensuring the interaction events are logged from the actual UI click handlers used by the titlebar dropdown, rather than from command handlers that may not be invoked in that flow.
Changes:
- Move
logSessionsInteraction(..., 'addTask' | 'generateNewTask')from theAction2.run()implementations to the dropdown actionruncallbacks used byRunScriptActionViewItem. - Store
ITelemetryServiceonRunScriptActionViewItemso it can be used consistently by dropdown actions and passed to the dropdown widget.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/chat/browser/runScriptAction.ts | Relocates “Add Task” / “Generate New Task” telemetry logging to the titlebar dropdown action handlers to ensure events fire when users click those items. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
vijayupadya
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.