Skip to content

[cherry-pick] ChatSessionCustomizationProvider testing fixes#308098

Merged
joshspicer merged 1 commit intorelease/1.115from
cherry-pick/308071
Apr 6, 2026
Merged

[cherry-pick] ChatSessionCustomizationProvider testing fixes#308098
joshspicer merged 1 commit intorelease/1.115from
cherry-pick/308071

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

@vs-code-engineering vs-code-engineering bot commented Apr 6, 2026

Cherry-pick of #308071 from main.

Fixes several issues found during testing of the ChatSessionCustomizationProvider API (testing issue microsoft/vscode-internalbacklog#7330).

Commits

  • Delete individual hooks instead of entire hooks file — Uses JSONC removeProperty/applyEdits to surgically remove a single hook entry while preserving comments. Passes itemId in both inline and right-click context menus. Wraps in try/catch with error dialog for stale file contents. Fixes microsoft/vscode-internalbacklog#7381
  • Throw CancellationError when plugin trust dialog is declined — Properly throws so the catch handler resets the button to "Install" instead of showing "Installed". Updates 2 existing tests. Fixes microsoft/vscode-internalbacklog#7378
  • Check installed state when rendering marketplace plugin items — Uses isEqual URI comparison against IAgentPluginService.plugins. Also fixes the PluginBrowseMode fixture (was broken due to missing ICustomizationHarnessService mock). Fixes microsoft/vscode-internalbacklog#7379
  • Replace floppy disk icon with newFile icon for create plugin buttonFixes microsoft/vscode-internalbacklog#7373
  • Fix plugin page CSS: padding, back button, and focus outlines — microsoft/vscode-internalbacklog#7377, microsoft/vscode-internalbacklog#7384, microsoft/vscode-internalbacklog#7385
  • Show workspace folder name in provider path for multi-root workspaces — Uses labelService.getUriLabel() for file: URIs instead of basename(). Fixes microsoft/vscode-internalbacklog#7330

Companion PR: microsoft/vscode-copilot-chat#5005

@vs-code-engineering vs-code-engineering bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Apr 6, 2026
@joshspicer joshspicer requested a review from rebornix April 6, 2026 23:17
@joshspicer joshspicer enabled auto-merge (squash) April 6, 2026 23:17
@joshspicer joshspicer merged commit 9dad2f7 into release/1.115 Apr 6, 2026
19 checks passed
@joshspicer joshspicer deleted the cherry-pick/308071 branch April 6, 2026 23:23
@vs-code-engineering vs-code-engineering bot added this to the 1.115.0 milestone Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants