Fail screenshot CI if fixtures with tag blocks-ci change#308192
Merged
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI gate to ensure that component fixture screenshots tagged blocks-ci cannot change without updating a committed, CI-generated markdown manifest, and attempts to provide an in-PR suggestion to update the manifest when changes are detected.
Changes:
- Add a committed, CI-generated markdown file listing
blocks-cifixtures and their screenshot hashes/URLs. - Add a build script to generate/compare the expected markdown from the render manifest and emit a GitHub-suggestion-friendly diff.
- Update the screenshot GitHub Actions workflow to run the check, post a suggestion on PRs, and fail the job on mismatch.
Show a summary per file
| File | Description |
|---|---|
test/componentFixtures/blocks-ci-screenshots.md |
New committed “expected hashes” manifest for blocks-ci screenshot fixtures. |
build/lib/screenshotBlocksCi.ts |
New comparator/generator script used by CI to detect and report blocks-ci screenshot hash changes. |
.github/workflows/screenshot-test.yml |
Runs the new check in CI, posts a PR suggestion, and fails the workflow if blocks-ci hashes changed. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
Contributor
ulugbekna
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.