Skip to content

Fail screenshot CI if fixtures with tag blocks-ci change#308192

Merged
hediet merged 2 commits intomainfrom
hediet/b/secondary-goat
Apr 7, 2026
Merged

Fail screenshot CI if fixtures with tag blocks-ci change#308192
hediet merged 2 commits intomainfrom
hediet/b/secondary-goat

Conversation

@hediet
Copy link
Copy Markdown
Member

@hediet hediet commented Apr 7, 2026

No description provided.

@hediet hediet enabled auto-merge (rebase) April 7, 2026 10:58
@hediet hediet self-assigned this Apr 7, 2026
Copilot AI review requested due to automatic review settings April 7, 2026 10:58
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocks-ci screenshots changed

Apply the suggestion below to update the committed screenshots.

Comment thread test/componentFixtures/blocks-ci-screenshots.md Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a CI gate to ensure that component fixture screenshots tagged blocks-ci cannot change without updating a committed, CI-generated markdown manifest, and attempts to provide an in-PR suggestion to update the manifest when changes are detected.

Changes:

  • Add a committed, CI-generated markdown file listing blocks-ci fixtures and their screenshot hashes/URLs.
  • Add a build script to generate/compare the expected markdown from the render manifest and emit a GitHub-suggestion-friendly diff.
  • Update the screenshot GitHub Actions workflow to run the check, post a suggestion on PRs, and fail the job on mismatch.
Show a summary per file
File Description
test/componentFixtures/blocks-ci-screenshots.md New committed “expected hashes” manifest for blocks-ci screenshot fixtures.
build/lib/screenshotBlocksCi.ts New comparator/generator script used by CI to detect and report blocks-ci screenshot hash changes.
.github/workflows/screenshot-test.yml Runs the new check in CI, posts a PR suggestion, and fails the workflow if blocks-ci hashes changed.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread build/lib/screenshotBlocksCi.ts
Comment thread .github/workflows/screenshot-test.yml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Screenshot Changes

Base: 52feef4e Current: 2a64808b

Changed (1)

editor/inlineCompletions/WordReplacementView/Light
Before After
before after

@hediet hediet merged commit 7eab272 into main Apr 7, 2026
19 checks passed
@hediet hediet deleted the hediet/b/secondary-goat branch April 7, 2026 13:57
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants