Skip to content

agents fixes#308220

Merged
sandy081 merged 1 commit intomainfrom
sandy081/circular-crayfish
Apr 7, 2026
Merged

agents fixes#308220
sandy081 merged 1 commit intomainfrom
sandy081/circular-crayfish

Conversation

@sandy081
Copy link
Copy Markdown
Member

@sandy081 sandy081 commented Apr 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 7, 2026 14:02
@sandy081 sandy081 enabled auto-merge (squash) April 7, 2026 14:02
@sandy081 sandy081 self-assigned this Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Screenshot Changes

Base: 7eab2726 Current: 7302881b

Changed (2)

editor/inlineCompletions/SideBySideView/Light
Before After
before after
editor/suggestWidget/MethodCompletions/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies small “Agents” window cleanups and consistency fixes in the vs/sessions layer, mainly removing unused UI code and aligning URL opening behavior with the product’s configured protocol.

Changes:

  • Simplifies the Copilot chat sessions mode picker by removing unused slot bookkeeping and disabled-state toggling.
  • Removes unused/dead sessions chat picker implementations (including a sync indicator) from src/vs/sessions/contrib/chat/browser.
  • Updates “Open in VS Code” to use productService.urlProtocol and renames Agents-related debug launch configurations/user-data dir.
Show a summary per file
File Description
src/vs/sessions/contrib/copilotChatSessions/browser/modePicker.ts Removes unused slot element handling and disabled-class toggling from the mode picker trigger.
src/vs/sessions/contrib/chat/browser/syncIndicator.ts Deletes an unused sync indicator widget implementation.
src/vs/sessions/contrib/chat/browser/modePicker.ts Deletes an unused/obsolete file (header removed as part of file removal).
src/vs/sessions/contrib/chat/browser/modelPicker.ts Deletes an unused/obsolete file (header removed as part of file removal).
src/vs/sessions/contrib/chat/browser/chat.contribution.ts Uses productService.urlProtocol when constructing the URI to open VS Code.
.vscode/launch.json Renames Agents launch/compound configs and updates the Agents dev user data directory name.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 0

@sandy081 sandy081 merged commit d1094dc into main Apr 7, 2026
23 checks passed
@sandy081 sandy081 deleted the sandy081/circular-crayfish branch April 7, 2026 14:41
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants