Refactor enableThinking/reasoningEffort into IModelCapabilityOptions#308294
Merged
Refactor enableThinking/reasoningEffort into IModelCapabilityOptions#308294
Conversation
Contributor
Screenshot ChangesBase: Changed (5) |
joshspicer
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors per-request “thinking” and related model-capability toggles from flat IMakeChatRequestOptions fields into a single modelCapabilities?: IModelCapabilityOptions object, and centralizes model capability detection (tool search + context editing) while allowing endpoints to expose these capabilities via server-provided metadata.
Changes:
- Introduces
IModelCapabilityOptionsand replacesenableThinking/reasoningEffortwithmodelCapabilitiesonIMakeChatRequestOptions. - Moves tool-search/context-editing capability helpers into
chatModelCapabilities.tsand addssupportsToolSearch/supportsContextEditingtoIChatEndpoint. - Updates request builders and tool-calling loops to plumb
modelCapabilitiesthrough, plus adjusts related unit tests.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/networking/common/networking.ts | Adds IModelCapabilityOptions and nests request capability opt-ins under modelCapabilities. |
| extensions/copilot/src/platform/networking/common/anthropic.ts | Switches capability checks to use shared helpers + endpoint metadata fields. |
| extensions/copilot/src/platform/endpoint/test/node/messagesApi.spec.ts | Updates tests to use modelCapabilities for thinking/effort. |
| extensions/copilot/src/platform/endpoint/node/responsesApi.ts | Reads reasoning effort from options.modelCapabilities. |
| extensions/copilot/src/platform/endpoint/node/messagesApi.ts | Gates tool search/context editing/thinking using modelCapabilities flags. |
| extensions/copilot/src/platform/endpoint/node/chatEndpoint.ts | Plumbs server metadata into endpoint capability fields; adjusts anthropic-beta header assembly. |
| extensions/copilot/src/platform/endpoint/common/endpointProvider.ts | Extends model metadata supports with tool_search / context_editing. |
| extensions/copilot/src/platform/endpoint/common/chatModelCapabilities.ts | Hosts centralized tool-search/context-editing capability logic/constants. |
| extensions/copilot/src/extension/tools/node/toolSearchTool.ts | Imports supported-model list from centralized capabilities module. |
| extensions/copilot/src/extension/prompt/node/searchSubagentToolCallingLoop.ts | Switches loop fetch plumbing to pass modelCapabilities. |
| extensions/copilot/src/extension/prompt/node/executionSubagentToolCallingLoop.ts | Switches loop fetch plumbing to pass modelCapabilities. |
| extensions/copilot/src/extension/prompt/node/defaultIntentRequestHandler.ts | Constructs per-request modelCapabilities (thinking/effort/tool search/context editing). |
| extensions/copilot/src/extension/intents/node/toolCallingLoop.ts | Updates fetch options typing and populates modelCapabilities (thinking). |
| extensions/copilot/src/extension/externalAgents/node/oaiLanguageModelServer.ts | Updates proxy request to enable thinking via modelCapabilities. |
| extensions/copilot/src/extension/conversation/vscode-node/languageModelAccess.ts | Moves reasoning effort into modelCapabilities. |
| extensions/copilot/src/extension/chatSessions/claude/node/claudeLanguageModelServer.ts | Updates proxy request to enable thinking via modelCapabilities. |
Copilot's findings
- Files reviewed: 16/16 changed files
- Comments generated: 5
71eb474 to
4d6564c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of microsoft/vscode-copilot-chat#5026.
Refactors flat
enableThinkingandreasoningEffortfields onIMakeChatRequestOptionsinto a singlemodelCapabilities?: IModelCapabilityOptionsobject. Also moves model capability check helpers (TOOL_SEARCH_SUPPORTED_MODELS,modelSupportsToolSearch,modelSupportsContextEditing) fromanthropic.tstochatModelCapabilities.ts, and addssupportsToolSearch/supportsContextEditingfields toIChatEndpointso they can be set from server-side metadata.