fixes flaky fixtures by hediet · Pull Request #308295 · microsoft/vscode

hediet · 2026-04-07T18:32:28Z

No description provided.

github-actions · 2026-04-07T18:35:26Z

Screenshot Changes

Base: fc99d59e Current: e8ff4a64

Changed (144)

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ZeroOfZero/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/SingleFeedback/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/SingleFeedback/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/FirstOfThree/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/FirstOfThree/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ReviewOnlyTwoComments/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ReviewOnlyTwoComments/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MiddleOfThree/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MiddleOfThree/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MixedFourComments/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MixedFourComments/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/LastOfThree/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/LastOfThree/Light

Before	After

sessions/aiCustomizationShortcutsWidget/WithMcpServers/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/WithMcpServers/Light

Before	After

sessions/aiCustomizationShortcutsWidget/WithCounts/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/WithCounts/Light

Before	After

chat/aiStats/AiStatsHover/Dark

Before	After

chat/aiStats/AiStatsHover/Light

Before	After

chat/aiStats/AiStatsHoverNoData/Dark

Before	After

chat/aiStats/AiStatsHoverNoData/Light

Before	After

editor/inlineCompletions/SideBySideView/Light

Before	After

editor/inlineCompletions/WordReplacementView/Dark

Before	After

editor/inlineCompletions/WordReplacementView/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ZeroOfZero/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedSingleComment/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedSingleComment/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedSingleComment/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedSingleComment/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedMultiComment/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedMultiComment/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMultiComment/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMultiComment/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedFeedback/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedFeedback/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewOnly/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewOnly/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMixedComments/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMixedComments/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedReviewComment/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedReviewComment/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewSuggestion/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewSuggestion/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedPRReviewOnly/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedPRReviewOnly/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedAllSourcesMixed/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedAllSourcesMixed/Light

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedPRReview/Dark

Before	After

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedPRReview/Light

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedEmpty/Dark

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedEmpty/Light

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedFilled/Dark

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedFilled/Light

Before	After

sessions/runScriptCustomTaskWidget/UserSelectedCheckedEmpty/Dark

Before	After

sessions/runScriptCustomTaskWidget/UserSelectedCheckedEmpty/Light

Before	After

sessions/runScriptCustomTaskWidget/UserSelectedCheckedFilled/Dark

Before	After

sessions/runScriptCustomTaskWidget/UserSelectedCheckedFilled/Light

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedEmpty/Dark

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedEmpty/Light

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedFilled/Dark

Before	After

sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedFilled/Light

Before	After

sessions/runScriptCustomTaskWidget/ExistingUserTaskLockedChecked/Dark

Before	After

sessions/runScriptCustomTaskWidget/ExistingUserTaskLockedChecked/Light

Before	After

sessions/aiCustomizationShortcutsWidget/Expanded/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/Expanded/Light

Before	After

chat/chatProgressContentPart/WithCustomIcon/Dark

Before	After

chat/chatProgressContentPart/WithCustomIcon/Light

Before	After

chat/chatQuestionCarousel/SingleTextQuestion/Dark

Before	After

chat/chatQuestionCarousel/SingleTextQuestion/Light

Before	After

chat/chatQuestionCarousel/SingleSelectQuestion/Dark

Before	After

chat/chatQuestionCarousel/SingleSelectQuestion/Light

Before	After

chat/chatQuestionCarousel/MultiSelectQuestion/Dark

Before	After

chat/chatQuestionCarousel/MultiSelectQuestion/Light

Before	After

chat/chatQuestionCarousel/MultipleQuestions/Dark

Before	After

chat/chatQuestionCarousel/MultipleQuestions/Light

Before	After

chat/chatQuestionCarousel/NoSkip/Dark

Before	After

chat/chatQuestionCarousel/NoSkip/Light

Before	After

chat/promptFilePickers/PromptFiles/Dark

Before	After

chat/promptFilePickers/PromptFiles/Light

Before	After

chat/promptFilePickers/InstructionFilesWithAgentInstructions/Dark

Before	After

chat/promptFilePickers/InstructionFilesWithAgentInstructions/Light

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Dark

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Light

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Dark

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/CliHarness/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/CliHarness/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/ClaudeHarness/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/ClaudeHarness/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light

Before	After

baseUI/Buttons/Dark

Before	After

baseUI/Buttons/Light

Before	After

baseUI/ButtonBar/Dark

Before	After

baseUI/ButtonBar/Light

Before	After

baseUI/Toggles/Dark

Before	After

baseUI/Toggles/Light

Before	After

editor/codeActionList/SimpleQuickFixes/Dark

Before	After

editor/codeActionList/SimpleQuickFixes/Light

Before	After

editor/inlineCompletions/SideBySideView/Dark

Before	After

editor/inlineCompletionsExtras/HintsToolbar/Dark

Before	After

editor/inlineCompletionsExtras/HintsToolbar/Light

Before	After

editor/inlineCompletionsExtras/HintsToolbarHovered/Dark

Before	After

editor/inlineCompletionsExtras/HintsToolbarHovered/Light

Before	After

editor/inlineCompletionsExtras/JumpToHint/Dark

Before	After

editor/inlineCompletionsExtras/JumpToHint/Light

Before	After

editor/inlineCompletionsExtras/GutterMenu/Dark

Before	After

editor/inlineCompletionsExtras/GutterMenu/Light

Before	After

editor/suggestWidget/MethodCompletions/Dark

Before	After

editor/suggestWidget/MethodCompletions/Light

Before	After

editor/suggestWidget/MixedKinds/Dark

Before	After

editor/suggestWidget/MixedKinds/Light

Before	After

Copilot

Pull request overview

This PR aims to reduce flakiness in the component fixture/screenshot pipeline by making fixture rendering more deterministic (scheduler control + disabling animations) and ensuring required assets/services are available during CI screenshot runs.

Changes:

Add global fixture CSS to disable animations/transitions during component rendering.
Refactor fixture render scheduling/wait logic using TimeTravelScheduler + new AsyncSchedulerProcessor.waitFor(...).
Adjust fixture service stubbing and CI workflow (codicon font) to prevent runtime/asset-related instability.

Show a summary per file

File	Description
src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts	Imports fixture CSS, tweaks render scheduling/waiting, and adds a stub `createModelReference` implementation.
src/vs/workbench/test/browser/componentFixtures/fixtures.css	Introduces styles intended to disable animations/transitions in fixtures.
src/vs/workbench/test/browser/componentFixtures/chat/chatInput.fixture.ts	Updates service wiring for the chat input fixture (moves stubbing responsibility, adds `IFileDialogService`).
src/vs/base/test/common/timeTravelScheduler.ts	Refactors scheduler processor internals and adds `waitFor(...)` timeout helper.
.github/workflows/screenshot-test.yml	Copies `codicon.ttf` into the expected source location before transpiling/running screenshots.

Copilot's findings

Comments suppressed due to low confidence (3)

src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:660

installFakeRunWhenIdle(...) is added to disposableStore, but the TimeTravelScheduler + AsyncSchedulerProcessor backing it are disposed via schedulerStore.dispose() right after actualRender(). After that point, any runWhenIdle callbacks scheduled by components will enqueue work onto a scheduler that is no longer being processed, which can leave parts of the UI permanently stale or leak queued tasks. Either keep the scheduler/processor alive for the fixture lifetime, or dispose/restore the fake runWhenIdle together with schedulerStore (e.g. register the fake runWhenIdle disposable in schedulerStore).

This issue also appears in the following locations of the same file:

line 662
line 662

				schedulerStore.add(scheduler.installGlobally());
				disposableStore.add(installFakeRunWhenIdle((_targetWindow, callback, _timeout?) => {
					return scheduler.schedule({
						time: scheduler.now,
						run: () => {
							const deadline: IdleDeadline = {
								didTimeout: true,
								timeRemaining: () => 50,
							};
							callback(deadline);
						},
						source: {
							toString() { return 'runWhenIdle'; },
							stackTrace: undefined,
						},
					});
				}));

src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:673

The previous overall render timeout guard was removed. p.waitFor(1000) only times out the scheduler queue wait; if options.render(...) returns a Promise that hangs (or awaits real timers/events), the Promise.all([...]) can now block indefinitely and hang the screenshot run/CI job. Consider restoring an overall timeout around the combined render work (e.g. race the whole actualRender()/Promise.all against a real-time timeout) so failures fail fast instead of hanging.

				const result = options.render({ container, disposableStore, theme });

				const p2 = p.waitFor(1000);

				await Promise.all([
					result instanceof Promise ? result : Promise.resolve(),
					p2,
				]);
			}

			await actualRender();

src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:669

result instanceof Promise is a brittle way to detect async renders (it won’t await non-native thenables, and it’s unnecessary here). Using await result (works for both void and thenables) or Promise.resolve(result) would make this more robust and simpler.

				const result = options.render({ container, disposableStore, theme });

				const p2 = p.waitFor(1000);

				await Promise.all([
					result instanceof Promise ? result : Promise.resolve(),
					p2,
				]);

Files reviewed: 5/5 changed files
Comments generated: 3

Copilot · 2026-04-07T18:41:46Z

+	waitFor(virtualTimeMs: number): Promise<void> {
+		return Promise.race([
+			this.waitForEmptyQueue(),
+			new Promise<void>((_resolve, reject) =>
+				originalGlobalValues.setTimeout(() => {
+					const lastTasks = this._history.slice(-10).map(h => `${h.source.toString()}: ${h.source.stackTrace}`);
+					reject(new Error(`waitFor timed out after ${virtualTimeMs}ms (processed ${this._history.length} tasks, ${this.scheduler.getScheduledTasks().length} pending). These are the last ${lastTasks.length} scheduled tasks:\n${lastTasks.join('\n\n\n')}`));
+				}, virtualTimeMs)


The parameter name virtualTimeMs is misleading here because waitFor uses a real setTimeout to enforce a wall-clock timeout (it doesn’t advance/measure the TimeTravelScheduler's virtual time). Consider renaming to timeoutMs (or similar) to make the behavior clear to callers.

Suggested change

waitFor(virtualTimeMs: number): Promise<void> {

return Promise.race([

this.waitForEmptyQueue(),

new Promise<void>((_resolve, reject) =>

originalGlobalValues.setTimeout(() => {

const lastTasks = this._history.slice(-10).map(h => `${h.source.toString()}: ${h.source.stackTrace}`);

reject(new Error(`waitFor timed out after ${virtualTimeMs}ms (processed ${this._history.length} tasks, ${this.scheduler.getScheduledTasks().length} pending). These are the last ${lastTasks.length} scheduled tasks:\n${lastTasks.join('\n\n\n')}`));

}, virtualTimeMs)

waitFor(timeoutMs: number): Promise<void> {

return Promise.race([

this.waitForEmptyQueue(),

new Promise<void>((_resolve, reject) =>

originalGlobalValues.setTimeout(() => {

const lastTasks = this._history.slice(-10).map(h => `${h.source.toString()}: ${h.source.stackTrace}`);

reject(new Error(`waitFor timed out after ${timeoutMs}ms (processed ${this._history.length} tasks, ${this.scheduler.getScheduledTasks().length} pending). These are the last ${lastTasks.length} scheduled tasks:\n${lastTasks.join('\n\n\n')}`));

}, timeoutMs)

fixes flaky fixtures

1b89851

Copilot AI review requested due to automatic review settings April 7, 2026 18:32

hediet enabled auto-merge (rebase) April 7, 2026 18:32

hediet self-assigned this Apr 7, 2026

Copilot started reviewing on behalf of hediet April 7, 2026 18:34 View session

joshspicer approved these changes Apr 7, 2026

View reviewed changes

Copilot AI reviewed Apr 7, 2026

View reviewed changes

austindyoung mentioned this pull request Apr 7, 2026

[mirror] microsoft/vscode#308295 fixes flaky fixtures austindyoung/vscode-driftfence-mirror-fork#1219

Open

hediet merged commit da1fd60 into main Apr 7, 2026
27 checks passed

hediet deleted the hediet/b/international-reindeer branch April 7, 2026 18:54

vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes flaky fixtures#308295

fixes flaky fixtures#308295
hediet merged 1 commit intomainfrom
hediet/b/international-reindeer

hediet commented Apr 7, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hediet commented Apr 7, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Screenshot Changes

Changed (144)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants