Sessions: derive PR icon from live GitHubPullRequestModel

[osortega]

Summary

Fixes: #308242

Migrates PR state detection from static extension metadata to a reactive core feature. Session card PR icons now update automatically when the GitHubPullRequestModel polling detects state changes (e.g. merged, closed, draft) — no extension round-trip needed.

Changes

src/vs/sessions/contrib/github/common/types.ts

• Added computePullRequestIcon(state, isDraft?) — single source of truth for PR state → icon mapping
• Handles both GitHubPullRequestState enum values and the string states the extension writes to metadata (including 'draft')

src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts

• AgentSessionAdapter.gitHubInfo is now a derived() observable that combines:
  • Base info from extension metadata (owner, repo, prNumber, URL) — same as before
  • Live PR model from IGitHubService — reads prModel.pullRequest reactively
• Falls back to metadata-based icon if the PR model hasn't loaded yet
• Replaced inline icon switch in _extractPullRequestStateIcon with a call to the shared computePullRequestIcon helper
• Injected IGitHubService into CopilotChatSessionsProvider and passed to adapters

Architecture

Extension writes metadata (pullRequestUrl, pullRequestState)
    ↓ (initial seed — owner, repo, prNumber, URL)
AgentSessionAdapter._extractGitHubInfo(session)
    ↓
derived(reader => {
    base = _baseGitHubInfo.read(reader)     // from metadata
    livePR = prModel.pullRequest.read(reader) // reactive, from polling
    icon = computePullRequestIcon(livePR.state, livePR.isDraft)
    return { ...base, pullRequest: { ...base.pullRequest, icon } }
})
    ↓
ISession.gitHubInfo (observable, auto-updates)
    ↓
sessionsList.ts autorun → re-renders icon ✓

Notes

• No changes to polling behavior — existing GitHubActiveSessionRefreshContribution triggers refresh on session open, and existing polling handles the rest
• Extension still writes metadata for backward compat and initial state before the model loads
• PR model is cached by IGitHubService (keyed by owner/repo/prNumber), so multiple sessions for the same PR share a model

[Copilot]

Pull request overview

This PR updates Sessions’ pull request status icon rendering to use the live, reactive GitHubPullRequestModel (polled by the core sessions GitHub feature) instead of relying solely on extension-written, static session metadata—so PR icons can update automatically as PR state changes.

Changes:

• Added a shared computePullRequestIcon(state, isDraft?) helper to map PR state/draft → themed codicon.
• Made AgentSessionAdapter.gitHubInfo reactive via derived(), combining metadata seed info with live IGitHubService PR model state.
• Wired IGitHubService into CopilotChatSessionsProvider to supply adapters with the live PR model.

Show a summary per file

File	Description
src/vs/sessions/contrib/github/common/types.ts	Introduces shared PR state → icon mapping helper used by sessions UI.
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts	Switches PR icon derivation to a reactive observable that reads from GitHubPullRequestModel when available.
extensions/copilot/package-lock.json	Lockfile metadata updates (adds dev: true flags on some entries).

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 2

[github-actions]

Screenshot Changes

Base: 56fd4d60 Current: 08edd9b2

Changed (2)

chat/chatQuestionCarousel/SingleTextQuestion/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light

Before	After