Fix cropped install button outline in plugin list#308390
Merged
joshspicer merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI focus-outline clipping issue in the AI Customizations “Plugins” list by adjusting the focus styling of the gallery install button so its outline is rendered inside the element, avoiding clipping from overflow: hidden containers (as reported in #308206).
Changes:
- Add
outline-offset: -1pxto.mcp-gallery-install-button:focus-visible. - Align install-button focus treatment with the existing
.list-button-group .monaco-button:focus-visiblepattern used within.mcp-list-widget.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css | Adds a focused-outline offset for the gallery install button to prevent outline cropping within overflow-hidden list rows/widgets. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
joshspicer
force-pushed
the
copilot/cooperative-armadillo
branch
from
4790b81 to
105a750
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts focus styling in the AI Customization plugins/gallery list to prevent the Install button’s keyboard focus outline from being visually clipped by ancestor containers that use overflow: hidden, addressing issue #308206.
Changes:
- Add
outline-offset: -1pxto.mcp-gallery-install-button:focus-visibleso the focus outline renders inward instead of being cropped. - Align the install button’s focus treatment with the existing pattern already used for
.mcp-list-widget .list-button-group .monaco-button:focus-visible.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css | Adds inward focus outline offset for the gallery install button to avoid clipping inside overflow-hidden list rows/widgets. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
joshspicer
force-pushed
the
copilot/cooperative-armadillo
branch
2 times, most recently
from
b228394 to
86d0734
Compare
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Light
| Before | After |
|---|---|
 |
 |
pwang347
previously approved these changes
Apr 8, 2026
Move the install button out of the details footer to be a direct child of the gallery item container. This vertically centers the button alongside the text content via the parent's align-items:center layout. Add explicit description styling with truncation (ellipsis) for gallery items. Ensure the .details container has proper flex sizing with min-width:0 to prevent overflow. Apply outline-offset:-1px on the install button focus-visible state, matching the existing pattern, to prevent clipping by overflow:hidden ancestors. Fixes #308206 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joshspicer
force-pushed
the
copilot/cooperative-armadillo
branch
from
86d0734 to
6c4efc6
Compare
Yoyokrazy
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
outline-offset: -1pxto the gallery install button's:focus-visiblestate, matching the existing pattern used for.list-button-groupbuttons. This prevents the focus outline from being clipped byoverflow: hiddenon ancestor containers (list rows,.mcp-list-widget).Fixes #308206