Improve browser compatibility with modal editor#308399
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the integrated browser (BrowserView editor) behavior when the editor is used inside the modal editor overlay (workbench.editor.useModal: "all"), addressing a crash/instability scenario by reducing unnecessary overlay invalidations and tightening overlay overlap detection.
Changes:
- Filter overlay
MutationObserverevents to ignore changes originating from within the browser container subtree. - Refine overlay overlap detection by checking the topmost element at the overlap point (z-index/top-layer aware).
- Simplify the overlay pause message setup in
BrowserEditorby initializing localized text once during editor creation.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/browserView/electron-browser/overlayManager.ts |
Adjusts overlay mutation handling and overlap detection (adds overlap-center + elementFromPoint topmost check). |
src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts |
Initializes the overlay pause heading/detail strings once and removes per-update mutation of those nodes. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
…anager.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joshspicer
approved these changes
Apr 8, 2026
jruales
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307997